AO3-7425 Set word count when posting draft from Edit Tag page#5803
Open
mellowmarsach wants to merge 2 commits into
Open
AO3-7425 Set word count when posting draft from Edit Tag page#5803mellowmarsach wants to merge 2 commits into
mellowmarsach wants to merge 2 commits into
Conversation
sarken
changed the title
sarken
requested changes
May 22, 2026
Collaborator
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Thanks for working on this! I just have a couple small suggestions.
Comment on lines
+58
to
+65
| When I am on imit's works page | ||
| Then I should see "Drafts (1)" | ||
| When I follow "Drafts (1)" | ||
| Then I should see "Freeze Tag" | ||
| And I should see "Edit Tags" within "#main .own.work.blurb .actions" | ||
| When I follow "Edit Tags" | ||
| Then I should see "Post" | ||
| When I press "Post" |
Collaborator
There was a problem hiding this comment.
It's a little redundant to check for the presence of the things we're going to interact with (the tests will fail if they're not there to interact with), so could we shorten lines 58-65 a bit to something like:
And I view the work "Freeze Tag"
When I follow "Edit Tags"
And I press "Post"
Contributor
Author
There was a problem hiding this comment.
This code works. Thank you for the feedback!
| @@ -405,6 +405,8 @@ def update_tags | |||
Collaborator
There was a problem hiding this comment.
I know it was already here, but could you remove this code comment? It's definitely misleading because we're posting the draft, not saving it.
Contributor
Author
There was a problem hiding this comment.
Comment removed
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7425
Purpose
Fix word count when posting draft from Edit Tag page
Credit
mellowmarsach