Resize bug

[adriendst]

Hello, I am using the library and I noticed some malfunction. I don't know if they are already known, so I wanted to share them to you.

The first one is :

bug.splitpane.1.mp4

In that case, when the top pane reach his minSize, he can still be minimized a little bit. Moreover, the when the top pane is smaller than his minSize, the bottom pane size reduce too. In the DOM we can see that the combined height of the three panes are over 100%.

The second one is :

bug.splitpane.2.mp4

In that case, when the first pane reach the end of the splitPanes component, both the first and last pane shrinks. The combined width of the three panes are less than 100%.

I was wondering if you could look at them ? Don't hesitate to ask me for more information :) (both the videos have been recorded from https://orefalo.github.io/svelte-splitpanes/ )

[orefalo]

Morning @adriendst,

Thank you so much for reporting the issues. I knew about the first one, not the second.

I honestly don't know when I will free up time to look into those.

[adriendst]

Okay, let me know when you will get into it ! I did some adjustment in my own code to avoid those bugs for the moment

[hopperelec]

I've also experienced both of these issues while working on this PR in a separate repo. It is worth adding that there seems to be a discrepancy between what happens in Chromium- and Firefox-based browsers, which I and the other repo's maintainer have discussed more in the PR I linked.

[orefalo]

Identified the issue. it's a regression bug. may have to revert passive events.

anyways, stick to v0.8.2 for now

[orefalo]

found the bug. expect a release soon

[orefalo]

I believe this bug is resolved in version 8.0.6.
Please try

[hopperelec]

I'll try it, thanks! By the way, are you intentionally sticking with the 8 major versioning?

[hopperelec]

The first issue seems to be fixed, but I'm still having an issue which most closely resembles the second issue. I'm not entirely sure what's causing it- as far as I understand, I'm not using any of the sizing parameters in any extraordinary ways- but if I set the initial size at all, then:

• In Chromium-based browsers, the initial size for all panes will be 0
• In Firefox-based browsers, the initial size is proportional to what was set, but slightly higher. For example, if I have a 1000px container and set the initial size to 40%, I expect the size to be 400px, but it is 441.33px

[hopperelec]

After a bit more testing, this seems to actually be an issue with reactivity. I'll try and fix the issue in the PR and hopefully I'll then have a better idea of exactly what it is.

[hopperelec]

I don't recall getting this before, but I am now noticing these errors.

They only happen in Chromium and if the size has been set. If the issue occurs, they happen at the same time as the size changing to 0, but they also happen even if the issue doesn't occur. The issue seems to occur if the size starts as null/undefined then changes reactively to a numeric value. The error seems to indicate that the pane itself somehow becomes undefined. I have not yet found a fix for this.

[orefalo]

Good morning,

Regarding the version, I am sticking to 8.x.x. I made a mistake a few weeks ago, and it was too late to withdraw the package from npm. I plan to port to Svelte 5 as 9.x.x.

Regarding the exception, those are good tips. I will investigate. A REPL to reproduce the error would be helpful.

Best regards,

PS: size should not be null. set it to 0

[orefalo]

Seems to be going through this code.

  const reportGivenSizeChangeSafe = (size: number) => {
    // We put an extra check of `size != sz` here and not in the reactive statement, since we don't want a change
    //  of `sz` to trigger report.
    if (size != sz) {
      carefullClientCallbacks('reportGivenSizeChange')(size);
    }
  };
  $: {
    if (browser && size != null) {
      reportGivenSizeChangeSafe(size);
    }
  }

considering introducing a typeof value === 'number' but I need a REPL to test @hopperelec

[orefalo]

plz test the latest code changes in master - not release as a version yet.
if the bug comes from the component, it should fix it.
closing for now