[qa] Switched to double quotes (black formatter)

Author: nemesifier

docs/developer/extending.rst

@@ -197,9 +197,7 @@ Add the following to your ``settings.py``:
     MONITORING_ALERTSETTINGS_MODEL = "YOUR_MODULE_NAME.AlertSettings"
     # For extending device_monitoring app
     DEVICE_MONITORING_DEVICEDATA_MODEL = "YOUR_MODULE_NAME.DeviceData"
-    DEVICE_MONITORING_DEVICEMONITORING_MODEL = (
-        "YOUR_MODULE_NAME.DeviceMonitoring"
-    )
+    DEVICE_MONITORING_DEVICEMONITORING_MODEL = "YOUR_MODULE_NAME.DeviceMonitoring"
     DEVICE_MONITORING_WIFICLIENT_MODEL = "YOUR_MODULE_NAME.WifiClient"
     DEVICE_MONITORING_WIFISESSION_MODEL = "YOUR_MODULE_NAME.WifiSession"
 

docs/developer/utils.rst

@@ -115,9 +115,7 @@ An example usage has been shown below.
                 "verbose_name": "Ping PROBLEM",
                 "verb": "cannot be reached anymore",
                 "level": "warning",
-                "email_subject": _(
-                    "[{site.name}] {notification.target} is not reachable"
-                ),
+                "email_subject": _("[{site.name}] {notification.target} is not reachable"),
                 "message": _(
                     "The device [{notification.target}] {notification.verb} anymore by our ping "
                     "messages."

docs/user/settings.rst

@@ -495,9 +495,7 @@ do it:
 
 .. code-block:: python
 
-    OPENWISP_MONITORING_CHARTS = {
-        "traffic": {"colors": ["#000000", "#cccccc", "#111111"]}
-    }
+    OPENWISP_MONITORING_CHARTS = {"traffic": {"colors": ["#000000", "#cccccc", "#111111"]}}
 
 Adaptive Size Charts
 ~~~~~~~~~~~~~~~~~~~~

openwisp_monitoring/__init__.py

@@ -1,18 +1,18 @@
-VERSION = (1, 2, 0, 'alpha')
+VERSION = (1, 2, 0, "alpha")
 __version__ = VERSION  # alias
 
 
 def get_version():
-    version = '%s.%s' % (VERSION[0], VERSION[1])
+    version = "%s.%s" % (VERSION[0], VERSION[1])
     if VERSION[2]:
-        version = '%s.%s' % (version, VERSION[2])
-    if VERSION[3:] == ('alpha', 0):
-        version = '%s pre-alpha' % version
+        version = "%s.%s" % (version, VERSION[2])
+    if VERSION[3:] == ("alpha", 0):
+        version = "%s pre-alpha" % version
     else:
-        if VERSION[3] != 'final':
+        if VERSION[3] != "final":
             try:
                 rev = VERSION[4]
             except IndexError:
                 rev = 0
-            version = '%s%s%s' % (version, VERSION[3][0:1], rev)
+            version = "%s%s%s" % (version, VERSION[3][0:1], rev)
     return version

openwisp_monitoring/check/admin.py

@@ -3,12 +3,12 @@
 
 from openwisp_utils.admin import TimeReadonlyAdminMixin
 
-Check = load_model('check', 'Check')
+Check = load_model("check", "Check")
 
 
 @admin.register(Check)
 class CheckAdmin(TimeReadonlyAdminMixin, admin.ModelAdmin):
-    list_display = ['__str__', 'check_type', 'created', 'modified']
-    search_fields = ['name', 'object_id']
+    list_display = ["__str__", "check_type", "created", "modified"]
+    search_fields = ["name", "object_id"]
     # TODO: filters
     save_on_top = True

openwisp_monitoring/check/apps.py

@@ -7,18 +7,18 @@
 
 
 class CheckConfig(AppConfig):
-    name = 'openwisp_monitoring.check'
-    label = 'check'
-    verbose_name = _('Network Monitoring Checks')
+    name = "openwisp_monitoring.check"
+    label = "check"
+    verbose_name = _("Network Monitoring Checks")
 
     def ready(self):
         self._connect_signals()
 
     def _connect_signals(self):
-        Check = load_model('check', 'Check')
+        Check = load_model("check", "Check")
 
         post_save.connect(
             Check.auto_create_check_receiver,
-            sender=load_model('config', 'Device'),
-            dispatch_uid='auto_create_check',
+            sender=load_model("config", "Device"),
+            dispatch_uid="auto_create_check",
         )

openwisp_monitoring/check/base/models.py

@@ -18,57 +18,57 @@
 class AbstractCheck(TimeStampedEditableModel):
     name = models.CharField(max_length=64, db_index=True)
     is_active = models.BooleanField(
-        _('active'),
+        _("active"),
         default=True,
         db_index=True,
         help_text=_(
-            'whether the check should be run, related metrics collected and alerts sent'
+            "whether the check should be run, related metrics collected and alerts sent"
         ),
     )
-    description = models.TextField(blank=True, help_text=_('Notes'))
+    description = models.TextField(blank=True, help_text=_("Notes"))
     content_type = models.ForeignKey(
         ContentType, on_delete=models.CASCADE, null=True, blank=True
     )
     object_id = models.CharField(max_length=36, db_index=True, blank=True)
-    content_object = GenericForeignKey('content_type', 'object_id')
+    content_object = GenericForeignKey("content_type", "object_id")
     check_type = models.CharField(
-        _('check type'),
+        _("check type"),
         choices=app_settings.CHECK_CHOICES,
         db_index=True,
         max_length=128,
     )
     params = JSONField(
-        _('parameters'),
+        _("parameters"),
         default=dict,
         blank=True,
-        help_text=_('parameters needed to perform the check'),
-        load_kwargs={'object_pairs_hook': OrderedDict},
-        dump_kwargs={'indent': 4},
+        help_text=_("parameters needed to perform the check"),
+        load_kwargs={"object_pairs_hook": OrderedDict},
+        dump_kwargs={"indent": 4},
     )
 
     class Meta:
         abstract = True
-        unique_together = ('name', 'object_id', 'content_type')
+        unique_together = ("name", "object_id", "content_type")
         indexes = [
             models.Index(
-                fields=['content_type', 'object_id', 'is_active'],
-                name='active_object_checks_idx',
+                fields=["content_type", "object_id", "is_active"],
+                name="active_object_checks_idx",
             )
         ]
 
         permissions = (
-            ('add_check_inline', 'Can add check inline'),
-            ('change_check_inline', 'Can change check inline'),
-            ('delete_check_inline', 'Can delete check inline'),
-            ('view_check_inline', 'Can view check inline'),
+            ("add_check_inline", "Can add check inline"),
+            ("change_check_inline", "Can change check inline"),
+            ("delete_check_inline", "Can delete check inline"),
+            ("view_check_inline", "Can view check inline"),
         )
 
     def __str__(self):
         if not self.object_id or not self.content_type:
             return self.name
         obj = self.content_object
         model_name = obj.__class__.__name__
-        return '{0} ({1}: {2})'.format(self.name, model_name, obj)
+        return "{0} ({1}: {2})".format(self.name, model_name, obj)
 
     def clean(self):
         self.check_instance.validate()
@@ -95,10 +95,10 @@ def check_instance(self):
     def perform_check(self, store=True):
         """Initializes check instance and calls the check method."""
         if (
-            hasattr(self.content_object, 'is_deactivated')
+            hasattr(self.content_object, "is_deactivated")
             and self.content_object.is_deactivated()
         ) or (
-            hasattr(self.content_object, 'organization_id')
+            hasattr(self.content_object, "organization_id")
             and self.content_object.organization.is_active is False
         ):
             return

openwisp_monitoring/check/checks.py

@@ -8,14 +8,14 @@
 @register()
 def check_wifi_clients_snooze_schedule(app_configs, **kwargs):
     errors = []
-    setting_name = 'OPENWISP_MONITORING_WIFI_CLIENTS_CHECK_SNOOZE_SCHEDULE'
+    setting_name = "OPENWISP_MONITORING_WIFI_CLIENTS_CHECK_SNOOZE_SCHEDULE"
     schedule = app_settings.WIFI_CLIENTS_CHECK_SNOOZE_SCHEDULE
 
     if not isinstance(schedule, (list, tuple)):
         errors.append(
             Error(
-                'Invalid schedule format',
-                hint='Schedule must be a list of date-time ranges',
+                "Invalid schedule format",
+                hint="Schedule must be a list of date-time ranges",
                 obj=setting_name,
             )
         )
@@ -25,8 +25,8 @@ def check_wifi_clients_snooze_schedule(app_configs, **kwargs):
         if not isinstance(item, (list, tuple)) or len(item) != 2:
             errors.append(
                 Error(
-                    f'Invalid schedule entry format: {item}',
-                    hint='Each schedule entry must be a pair of start and end times',
+                    f"Invalid schedule entry format: {item}",
+                    hint="Each schedule entry must be a pair of start and end times",
                     obj=setting_name,
                 )
             )
@@ -36,7 +36,7 @@ def check_wifi_clients_snooze_schedule(app_configs, **kwargs):
         if not isinstance(start, str) or not isinstance(end, str):
             errors.append(
                 Error(
-                    f'Invalid time format: {item}',
+                    f"Invalid time format: {item}",
                     hint='Use format "MM-DD HH:MM", "MM-DD", or "HH:MM"',
                     obj=setting_name,
                 )
@@ -45,29 +45,29 @@ def check_wifi_clients_snooze_schedule(app_configs, **kwargs):
 
         try:
             # Check if both are time format (HH:MM)
-            if '-' not in start and '-' not in end:
-                datetime.strptime(start, '%H:%M')
-                datetime.strptime(end, '%H:%M')
+            if "-" not in start and "-" not in end:
+                datetime.strptime(start, "%H:%M")
+                datetime.strptime(end, "%H:%M")
             # Check if both are date format (MM-DD)
-            elif ':' not in start and ':' not in end:
-                datetime.strptime(start, '%m-%d')
-                datetime.strptime(end, '%m-%d')
+            elif ":" not in start and ":" not in end:
+                datetime.strptime(start, "%m-%d")
+                datetime.strptime(end, "%m-%d")
             # Check if both are date-time format (MM-DD HH:MM)
             elif len(start.split()) == 2 and len(end.split()) == 2:
-                datetime.strptime(start, '%m-%d %H:%M')
-                datetime.strptime(end, '%m-%d %H:%M')
+                datetime.strptime(start, "%m-%d %H:%M")
+                datetime.strptime(end, "%m-%d %H:%M")
             else:
                 errors.append(
                     Error(
-                        f'Inconsistent format: {item}',
-                        hint='Both start and end must be in the same format (either both time or both date)',
+                        f"Inconsistent format: {item}",
+                        hint="Both start and end must be in the same format (either both time or both date)",
                         obj=setting_name,
                     )
                 )
         except ValueError:
             errors.append(
                 Error(
-                    f'Invalid date-time format: {item}',
+                    f"Invalid date-time format: {item}",
                     hint='Use format "MM-DD HH:MM", "MM-DD", or "HH:MM"',
                     obj=setting_name,
                 )

openwisp_monitoring/check/classes/base.py

@@ -7,9 +7,9 @@
 
 logger = logging.getLogger(__name__)
 
-Check = load_model('check', 'Check')
-Metric = load_model('monitoring', 'Metric')
-Device = load_model('config', 'Device')
+Check = load_model("check", "Check")
+Metric = load_model("monitoring", "Metric")
+Device = load_model("config", "Device")
 
 
 class BaseCheck(object):
@@ -35,8 +35,8 @@ def validate_instance(self):
         # check instance is of type device
         obj = self.related_object
         if not obj or not isinstance(obj, Device):
-            message = 'A related device is required to perform this operation'
-            raise ValidationError({'content_type': message, 'object_id': message})
+            message = "A related device is required to perform this operation"
+            raise ValidationError({"content_type": message, "object_id": message})
 
     def validate(self):
         self.validate_instance()
@@ -82,14 +82,14 @@ def timed_check(self, store=True):
         start_time = time.time()
         result = self.check(store=store)
         elapsed_time = time.time() - start_time
-        if hasattr(self, '_store_result_elapsed_time'):
+        if hasattr(self, "_store_result_elapsed_time"):
             elapsed_time -= self._store_result_elapsed_time
         logger.info(
             'Check "%s" executed in %.2fs, writing took %.2fs'
             % (
                 self.check_instance,
                 elapsed_time,
-                getattr(self, '_store_result_elapsed_time', 0.0),
+                getattr(self, "_store_result_elapsed_time", 0.0),
             ),
         )
         return result

openwisp_monitoring/check/classes/config_applied.py

@@ -7,31 +7,31 @@
 from ..settings import CONFIG_CHECK_INTERVAL
 from .base import BaseCheck
 
-AlertSettings = load_model('monitoring', 'AlertSettings')
+AlertSettings = load_model("monitoring", "AlertSettings")
 
 
 class ConfigApplied(BaseCheck):
     @classmethod
     def get_related_metrics(cls):
-        return ('config_applied',)
+        return ("config_applied",)
 
     def check(self, store=True):
         # If the device is down or does not have a config
         # do not run config applied check
         if self.related_object.monitoring.status in [
-            'critical',
-            'unknown',
-        ] or not hasattr(self.related_object, 'config'):
+            "critical",
+            "unknown",
+        ] or not hasattr(self.related_object, "config"):
             return
         result = int(
-            self.related_object.config.status == 'applied'
+            self.related_object.config.status == "applied"
             or self.related_object.modified
             > timezone.now() - timedelta(minutes=CONFIG_CHECK_INTERVAL)
         )
         # If the device config is in error status we don't need to notify
         # the user (because that's already done by openwisp-controller)
         # but we need to ensure health status will be changed
-        send_alert = self.related_object.config.status != 'error'
+        send_alert = self.related_object.config.status != "error"
         if store:
             self.timed_store(result, send_alert)
         return result
@@ -42,7 +42,7 @@ def store(self, result, send_alert, **kwargs):
         )
 
     def _get_metric(self):
-        metric, created = self._get_or_create_metric(configuration='config_applied')
+        metric, created = self._get_or_create_metric(configuration="config_applied")
         if created:
             self._create_alert_setting(metric)
         return metric