Skip to content

Commit 1eba6a5

Browse files
asmodehnnemesifier
andauthored
[change] Add app_label attrs to TestAdmin in monitoring
Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
1 parent da08d2c commit 1eba6a5

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

openwisp_monitoring/monitoring/tests/test_admin.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,17 @@
66

77

88
class TestAdmin(TestMonitoringMixin, TestCase):
9+
app_label = "monitoring"
10+
check_app_label = "check"
11+
912
def _login_admin(self):
1013
User = get_user_model()
1114
u = User.objects.create_superuser("admin", "admin", "test@test.com")
1215
self.client.force_login(u)
1316

1417
def test_metric_admin(self):
1518
m = self._create_general_metric()
16-
url = reverse("admin:monitoring_metric_change", args=[m.pk])
19+
url = reverse(f"admin:{self.app_label}_metric_change", args=[m.pk])
1720
self._login_admin()
1821
r = self.client.get(url)
1922
self.assertEqual(r.status_code, 200)
@@ -24,7 +27,7 @@ def test_alert_settings_inline(self):
2427
self.assertIsNone(alert_s.custom_operator)
2528
self.assertIsNone(alert_s.custom_threshold)
2629
self.assertIsNone(alert_s.custom_tolerance)
27-
url = reverse("admin:monitoring_metric_change", args=[m.pk])
30+
url = reverse(f"admin:{self.app_label}_metric_change", args=[m.pk])
2831
self._login_admin()
2932
r = self.client.get(url)
3033
self.assertEqual(r.status_code, 200)
@@ -37,10 +40,10 @@ def test_admin_menu_groups(self):
3740
self._login_admin()
3841
response = self.client.get(reverse("admin:index"))
3942
with self.subTest("test menu group link for check model"):
40-
url = reverse("admin:check_check_changelist")
43+
url = reverse(f"admin:{self.check_app_label}_check_changelist")
4144
self.assertContains(response, f'class="mg-link" href="{url}"')
4245
with self.subTest("test menu group link for metric model"):
43-
url = reverse("admin:monitoring_metric_changelist")
46+
url = reverse(f"admin:{self.app_label}_metric_changelist")
4447
self.assertContains(response, f'class="mg-link" href="{url}"')
4548
with self.subTest('test "monitoring" group is registered'):
4649
self.assertContains(

0 commit comments

Comments
 (0)