[tests] Remove redundant imports in regression test #572

- Removed redundant local imports for os and subprocess.
- Addressed CodeRabbit nitpick.

Fixes #572

Author: Piyushkhobragade

tests/runtests.py

@@ -239,15 +239,35 @@ def test_create_prefix_users(self):
 
     def test_openvpn_config_whitespace_handling(self):
         """Verify openvpn_config_download handles whitespace."""
-        import os, shlex, subprocess, tempfile
+        import shlex
+        import tempfile
+
         with tempfile.TemporaryDirectory() as tmpdir:
-            repo_root = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
-            u_path = os.path.join(repo_root, "images", "common", "utils.sh")
-            script = f"source {shlex.quote(u_path)}\ncurl() {{ true; }}\ntar() {{ touch 'my vpn with spaces.conf'; }}\nchmod() {{ true; }}\nUUID='x'; KEY='x'; API='http://x'\nopenvpn_config_download\nif [ -f 'openvpn.conf' ]; then echo 'PASS'; fi\n"
+            r_root = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
+            u_path = os.path.join(r_root, "images", "common", "utils.sh")
+            script = (
+                f"source {shlex.quote(u_path)}\n"
+                "curl() { true; }\n"
+                "tar() { touch 'my vpn with spaces.conf'; }\n"
+                "chmod() { true; }\n"
+                "UUID='x'; KEY='x'; API='http://x'\n"
+                "openvpn_config_download\n"
+                "if [ -f 'openvpn.conf' ]; then echo 'PASS'; fi\n"
+            )
             script_path = os.path.join(tmpdir, "test_mock.sh")
-            with open(script_path, "w") as sf: sf.write(script)
-            res = subprocess.run(["bash", script_path], cwd=tmpdir, capture_output=True, text=True)
-            self.assertEqual(res.returncode, 0, f"Mock script failed:\n{res.stdout}\n{res.stderr}")
+            with open(script_path, "w") as sf:
+                sf.write(script)
+            res = subprocess.run(
+                ["bash", script_path],
+                cwd=tmpdir,
+                capture_output=True,
+                text=True,
+            )
+            self.assertEqual(
+                res.returncode,
+                0,
+                f"Mock script failed:\n{res.stdout}\n{res.stderr}",
+            )
             self.assertIn("PASS", res.stdout)
 
     def test_console_errors(self):