Add SetProcessKind#271
Merged
Merged
Conversation
kolyshkin
requested review from
cyphar,
mrunalp,
rhatdan,
runcom and
thaJeztah
as code owners
kolyshkin
force-pushed
the
change-type
branch
2 times, most recently
from
7ca5651 to
f07753b
Compare
thaJeztah
reviewed
May 12, 2026
Collaborator
Author
thaJeztah
reviewed
May 18, 2026
kolyshkin
commented
May 19, 2026
Comment on lines
+52
to
+58
| type LabelType int | ||
|
|
||
| const ( | ||
| TypeProcess LabelType = 1 | ||
| TypeInitProcess LabelType = 2 | ||
| TypeKVMProcess LabelType = 3 | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Maybe change Type to Kind?
Collaborator
Author
There was a problem hiding this comment.
Changed
- ChangeLabelType → SetProcessKind
- LabelType → ProcessKind
- Type{Process,InitProcess,KVMProcess} → ProcessKind{Regular,Init,KVM}
kolyshkin
commented
May 19, 2026
All (open source) users of KVMContainerLabel[s] and InitContainerLabel[s] (containerd, podman, and cri-o) are immediately releasing the acquired MCS. They only need the type field, so they can change the existing label to that type. Everything else, including the just-generated unique MCS label, is not used. Introduce SetProcessKind which does just what all those users need. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Collaborator
|
The kind versus type here is not really an SELinux thing. These are move Containers/VM Labels that leaked into this repository. So the upstream SELinux people would have no opinion. LGTM |
rhatdan
approved these changes
May 21, 2026
chhe
pushed a commit
to chhe/act_runner
that referenced
this pull request
May 22, 2026
… (#990) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) | `v1.14.1` → `v1.15.0` |  |  | --- ### Release Notes <details> <summary>opencontainers/selinux (github.com/opencontainers/selinux)</summary> ### [`v1.15.0`](https://github.com/opencontainers/selinux/releases/tag/v1.15.0) [Compare Source](opencontainers/selinux@v1.14.1...v1.15.0) This release adds a new function, SetProcessKind, which is to be used instead of KVMProcessLabel\[s] and InitProcessLabel\[s] in case the user only wants to change the type of the existing label, not generate a new one. It also fixes an CI issue and optimizes label.InitLabels for a few common cases. #### What's Changed - ci: set timeout for vm jobs by [@​kolyshkin](https://github.com/kolyshkin) in [#​270](opencontainers/selinux#270) - label.InitLabels: optimize by [@​kolyshkin](https://github.com/kolyshkin) in [#​269](opencontainers/selinux#269) - Add SetProcessKind by [@​kolyshkin](https://github.com/kolyshkin) in [#​271](opencontainers/selinux#271) **Full Changelog**: <opencontainers/selinux@v1.14.1...v1.15.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xOTAuMSIsInVwZGF0ZWRJblZlciI6IjQzLjE5MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://gitea.com/gitea/runner/pulls/990 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Renovate Bot <renovate-bot@gitea.com> Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All (open source) users of
KVMContainerLabel[s]andInitContainerLabel[s](containerd, podman, and cri-o) are immediately releasing the acquired MCS. They only need the type field, so they can change the existing label to that type. Everything else, including the just-generated unique MCS label, is not used.Introduce
SetProcessKindwhich does just what all those users need.Fixes: #266
Testing this: