fix: Fixed some user related errors being incorrectly sent to Sentry.

Author: Skyost

lib/i18n/de/error.json

@@ -39,6 +39,7 @@
   },
   "backend": {
     "invalidJsonResponse": "Ungültige Antwort vom $route (HTTP $statusCode) : $body.",
+    "expiredCode": "Der Bestätigungscode ist abgelaufen. Bitte versuchen Sie sich erneut einzuloggen.",
     "noEmailToConfirm": "Keine E-Mail zum Bestätigen.",
     "invalidSession": "Ihre Sitzung ist ungültig. Bitte versuchen Sie sich erneut einzuloggen.",
     "noSession": "Sie müssen sich einloggen, um fortzufahren.",

lib/i18n/en/error.json

@@ -39,6 +39,7 @@
   },
   "backend": {
     "invalidJsonResponse": "Invalid response from $route (HTTP $statusCode) : $body.",
+    "expiredCode": "The verification code has expired. Please try to log-in again.",
     "noEmailToConfirm": "No email to confirm.",
     "invalidSession": "Your session is invalid. Please try to log-in again.",
     "noSession": "You must be logged-in to proceed.",

lib/i18n/fr/error.json

@@ -40,6 +40,7 @@
   "backend": {
     "invalidJsonResponse": "Réponse invalide du $route (HTTP $statusCode) : $body.",
     "noEmailToConfirm": "Aucun email à confirmer.",
+    "expiredCode": "Le code de vérification a expiré. Veuillez réessayer de vous connecter.",
     "invalidSession": "Votre session est invalide. Veuillez réessayer de vous connecter.",
     "noSession": "Vous devez être connecté pour continuer.",
     "emailAlreadySent": "Un email a déjà été envoyé à cette adresse. Veuillez vérifier votre boîte mail ou réessayer dans quelques minutes.",

lib/i18n/it/error.json

@@ -40,6 +40,7 @@
   "backend": {
     "invalidJsonResponse": "Risposta non valida dal $route (HTTP $statusCode) : $body.",
     "noEmailToConfirm": "Nessun email da confermare.",
+    "expiredCode": "Il codice di verifica è scaduto. Riprova a effettuare il login.",
     "invalidSession": "La tua sessione non è valida. Riprova a effettuare il login.",
     "noSession": "Devi effettuare il login per continuare.",
     "emailAlreadySent": "Un email è già stata inviata a questa indirizzo. Controlla la tua posta elettronica o riprova tra qualche minuto.",

lib/i18n/pt/error.json

@@ -40,6 +40,7 @@
   "backend": {
     "invalidJsonResponse": "Resposta inválida do $route (HTTP $statusCode) : $body.",
     "noEmailToConfirm": "Nenhum e-mail para confirmar.",
+    "expiredCode": "O código de verificação expirou. Tente novamente para fazer login.",
     "invalidSession": "Sua sessão é inválida. Tente novamente para fazer login.",
     "noSession": "Você deve estar logado para prosseguir.",
     "emailAlreadySent": "Um e-mail já foi enviado para este endereço. Verifique sua caixa de entrada ou tente novamente em alguns minutos.",

lib/main.dart

@@ -245,10 +245,16 @@ class _RouteWidgetState extends ConsumerState<_RouteWidget> {
           }
           Uri uri = next.value!;
           if (uri.scheme == 'openauthenticator') {
+            if (!ref.read(appLinksListenerProvider.notifier).consumeLink(uri)) {
+              return;
+            }
             WidgetsBinding.instance.addPostFrameCallback((_) => handleAppLink(uri));
             return;
           }
           if (uri.scheme == 'otpauth') {
+            if (!ref.read(appLinksListenerProvider.notifier).consumeLink(uri)) {
+              return;
+            }
             WidgetsBinding.instance.addPostFrameCallback((_) => handleTotpLink(uri));
             return;
           }
@@ -319,7 +325,7 @@ class _RouteWidgetState extends ConsumerState<_RouteWidget> {
       if (mounted) {
         context.handleResult(
           result,
-          successMessage: result.valueOrNull?.localizedMessage,
+          successMessage: (value) => value.localizedMessage,
         );
       }
     }

lib/model/backend/authentication/providers/email.dart

@@ -76,6 +76,9 @@ class EmailAuthenticationProvider extends AuthenticationProvider {
             ),
           );
       if (response is! ResultSuccess<EmailConfirmResponse>) {
+        if (response is ResultError<EmailConfirmResponse> && response.exception is ExpiredCodeError) {
+          await _ref.read(emailConfirmationStateProvider.notifier)._cancelConfirmation();
+        }
         return response.to((_) => null);
       }
       Uri uri = response.value.url;

lib/model/backend/authentication/providers/provider.dart

@@ -6,6 +6,7 @@ import 'package:open_authenticator/i18n/localizable_exception.dart';
 import 'package:open_authenticator/i18n/translations.g.dart';
 import 'package:open_authenticator/model/backend/authentication/session.dart';
 import 'package:open_authenticator/model/backend/backend.dart';
+import 'package:open_authenticator/model/backend/request/error.dart';
 import 'package:open_authenticator/model/backend/request/request.dart';
 import 'package:open_authenticator/model/backend/request/response.dart';
 import 'package:open_authenticator/model/backend/user.dart';

lib/model/backend/backend.dart

@@ -117,6 +117,15 @@ class BackendClient extends AsyncNotifier<Map<String, String>> {
       return ResultError(
         exception: ex,
         stackTrace: stackTrace,
+        sendToSentry: switch (ex) {
+          SocketException(:final osError) => osError?.errorCode != 7,
+          TimeoutException() => false,
+          ProviderUserAlreadyExists() => false,
+          ExpiredCodeError() => false,
+          InvalidVerificationCodeError() => false,
+          InvalidAuthorizationCodeError() => false,
+          _ => true,
+        },
       );
     }
   }

lib/model/backend/request/error.dart

@@ -59,20 +59,32 @@ class BackendRequestError extends LocalizableException {
           statusCode: statusCode,
           message: message,
         );
+      case ExpiredCodeError.kErrorCode:
+        return ExpiredCodeError._(
+          route: route,
+          statusCode: statusCode,
+          message: message,
+        );
       case InvalidVerificationCodeError.kErrorCode:
         return InvalidVerificationCodeError._(
           route: route,
           statusCode: statusCode,
           message: message,
         );
+      case InvalidAuthorizationCodeError.kErrorCode:
+        return InvalidAuthorizationCodeError._(
+          route: route,
+          statusCode: statusCode,
+          message: message,
+        );
       case InvalidAppVersionError.kErrorCode:
         return InvalidAppVersionError._(
           route: route,
           statusCode: statusCode,
           message: message,
         );
-      case _ProviderUserAlreadyExists.kErrorCode:
-        return _ProviderUserAlreadyExists._(
+      case ProviderUserAlreadyExists.kErrorCode:
+        return ProviderUserAlreadyExists._(
           route: route,
           statusCode: statusCode,
           message: message,
@@ -158,6 +170,22 @@ class InvalidSessionError extends BackendRequestError {
        );
 }
 
+/// Thrown when the verification code is expired.
+class ExpiredCodeError extends BackendRequestError {
+  /// The expired code error code.
+  static const String kErrorCode = 'expiredCode';
+
+  /// Creates a new expired code error instance.
+  ExpiredCodeError._({
+    required super.route,
+    required super.statusCode,
+    super.message,
+  }) : super._(
+         localizedErrorMessage: translations.error.backend.expiredCode,
+         code: kErrorCode,
+       );
+}
+
 /// Thrown when the verification code is invalid.
 class InvalidVerificationCodeError extends BackendRequestError {
   /// The invalid verification code error code.
@@ -174,6 +202,22 @@ class InvalidVerificationCodeError extends BackendRequestError {
        );
 }
 
+/// Thrown when the provider authorization code is invalid.
+class InvalidAuthorizationCodeError extends BackendRequestError {
+  /// The invalid authorization code error code.
+  static const String kErrorCode = 'invalidAuthorizationCode';
+
+  /// Creates a new invalid authorization code error instance.
+  InvalidAuthorizationCodeError._({
+    required super.route,
+    required super.statusCode,
+    super.message,
+  }) : super._(
+         localizedErrorMessage: translations.error.backend.invalidVerificationCode,
+         code: kErrorCode,
+       );
+}
+
 /// Thrown when the app version is invalid.
 class InvalidAppVersionError extends BackendRequestError {
   /// The invalid app version error code.
@@ -191,12 +235,12 @@ class InvalidAppVersionError extends BackendRequestError {
 }
 
 /// Thrown when the provider user already exists.
-class _ProviderUserAlreadyExists extends BackendRequestError {
+class ProviderUserAlreadyExists extends BackendRequestError {
   /// The provider user already exists error code.
   static const String kErrorCode = 'providerUserAlreadyExists';
 
   /// Creates a new expired session error instance.
-  _ProviderUserAlreadyExists._({
+  ProviderUserAlreadyExists._({
     required super.route,
     required super.statusCode,
     super.message,