fix(opentelemetry-kube-stack): quote env var values in Instrumentation template (#2155)

* fix(opentelemetry-kube-stack): quote env var values in Instrumentation template

Numeric env var values passed to the Instrumentation resource caused
validation errors because they were rendered as bare integers instead of
strings. This is especially common when using the chart as a subchart,
where YAML type coercion strips quotes from numeric strings.

Two fixes:
- Quote the value in the renderenvs template helper
- Accept both string and number types in the EnvVar JSON schema

Fixes #1888

Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>

* fix: format JSON array for pre-commit pretty-format-json

Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>

---------

Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>

Author: nicknikolakakis

charts/opentelemetry-kube-stack/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v2
 name: opentelemetry-kube-stack
-version: 0.14.11
+version: 0.14.12
 description: |
   OpenTelemetry Quickstart chart for Kubernetes.
   Installs an operator and collector for an easy way to get started with Kubernetes observability.

charts/opentelemetry-kube-stack/templates/_helpers.tpl

@@ -75,7 +75,7 @@ Render a deduped list of environment variables and 'extraEnvs'
 {{- end }}
 {{- range $key, $value := $envMap }}
 - name: {{ $key }}
-  value: {{ $value }}
+  value: {{ $value | quote }}
 {{- end }}
 {{- range $key, $value := $valueFromMap }}
 - name: {{ $key }}

charts/opentelemetry-kube-stack/values.schema.json

@@ -566,7 +566,10 @@
           "type": "string"
         },
         "value": {
-          "type": "string"
+          "type": [
+            "string",
+            "number"
+          ]
         },
         "valueFrom": {
           "$ref": "#/$defs/EnvVarSource"