Merge pull request #391 from oasisprotocol/kostko/feature/rofl-create-init-change

feat(cmd/rofl): Only create deployments in create not init

Author: kostko

build/rofl/manifest.go

@@ -55,7 +55,7 @@ type Manifest struct {
 	Artifacts *ArtifactsConfig `yaml:"artifacts,omitempty" json:"artifacts,omitempty"`
 
 	// Deployments are the ROFL app deployments.
-	Deployments map[string]*Deployment `yaml:"deployments" json:"deployments"`
+	Deployments map[string]*Deployment `yaml:"deployments,omitempty" json:"deployments,omitempty"`
 
 	// Scripts are custom scripts that are executed by the build system at specific stages.
 	Scripts map[string]string `yaml:"scripts,omitempty" json:"scripts,omitempty"`
@@ -150,9 +150,6 @@ func (m *Manifest) Validate() error {
 			return fmt.Errorf("bad deployment '%s': %w", name, err)
 		}
 	}
-	if _, ok := m.Deployments[DefaultDeploymentName]; !ok {
-		return fmt.Errorf("must define at least the '%s' deployment", DefaultDeploymentName)
-	}
 
 	return nil
 }

build/rofl/manifest_test.go

@@ -51,10 +51,10 @@ func TestManifestValidation(t *testing.T) {
 	err = m.Validate()
 	require.ErrorContains(err, "bad resources config: vCPU count must be at least 1")
 
-	// No default deployment.
+	// Should be valid without deployments.
 	m.Resources.CPUCount = 1
 	err = m.Validate()
-	require.ErrorContains(err, "must define at least the 'default' deployment")
+	require.NoError(err, "must work without deployments")
 
 	// Missing network in deployment.
 	m.Deployments = map[string]*Deployment{