Skip to content

Commit d005d20

Browse files
committed
fix(lint): remove unnecessary type assertions after dep updates
1 parent 5ebbcc9 commit d005d20

5 files changed

Lines changed: 16 additions & 16 deletions

File tree

packages/shardwire/src/bridge/transport/socket.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,13 @@ class StandardWebSocketAdapter implements WebSocketLike {
7676
this.openListeners.add(listener as () => void);
7777
break;
7878
case 'message':
79-
this.messageListeners.add(listener as (data: unknown) => void);
79+
this.messageListeners.add(listener);
8080
break;
8181
case 'close':
8282
this.closeListeners.add(listener as () => void);
8383
break;
8484
case 'error':
85-
this.errorListeners.add(listener as (error: unknown) => void);
85+
this.errorListeners.add(listener);
8686
break;
8787
default:
8888
break;

packages/shardwire/src/discord/runtime/discordjs-adapter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,7 +1114,7 @@ export class DiscordJsRuntimeAdapter implements DiscordRuntimeAdapter {
11141114
...(payload.topic !== undefined ? { topic: payload.topic } : {}),
11151115
...(payload.reason ? { reason: payload.reason } : {}),
11161116
} as never);
1117-
return serializeChannel(edited as Channel);
1117+
return serializeChannel(edited);
11181118
}
11191119

11201120
private async deleteChannel(payload: BotActionPayloadMap['deleteChannel']) {
@@ -1234,7 +1234,7 @@ export class DiscordJsRuntimeAdapter implements DiscordRuntimeAdapter {
12341234
);
12351235
}
12361236

1237-
let owner: unknown = this.client as unknown;
1237+
let owner: unknown = this.client;
12381238
let target: unknown = owner;
12391239
for (const part of parts) {
12401240
if (!target || (typeof target !== 'object' && typeof target !== 'function')) {

packages/shardwire/test/helpers/fake-runtime.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ export class FakeDiscordRuntime implements DiscordRuntimeAdapter {
4545
existing.add(handler);
4646
} else {
4747
this.eventHandlers[name] = new Set([
48-
handler as never as (payload: BotEventPayloadMap[BotEventName]) => void,
49-
]) as EventHandlers[K];
48+
handler as never,
49+
]);
5050
}
5151
return () => {
5252
const current = this.eventHandlers[name] as Set<(payload: BotEventPayloadMap[K]) => void> | undefined;
@@ -62,7 +62,7 @@ export class FakeDiscordRuntime implements DiscordRuntimeAdapter {
6262
if (!handler) {
6363
throw new Error(`No fake action handler registered for "${name}".`);
6464
}
65-
return handler(payload as never) as Promise<BotActionResultDataMap[K]>;
65+
return handler(payload as never);
6666
}
6767

6868
getClient(): unknown {

packages/shardwire/test/in-process.spec.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ describe('in-process app bridge', () => {
136136
const handler = ({ message }: { message: { id: string } }) => {
137137
seen.push(message.id);
138138
};
139-
const unsub = app.on('messageCreate', handler as never, { channelId: 'c1' });
139+
const unsub = app.on('messageCreate', handler, { channelId: 'c1' });
140140
runtime.emit('messageCreate', {
141141
receivedAt: Date.now(),
142142
message: {
@@ -159,7 +159,7 @@ describe('in-process app bridge', () => {
159159
});
160160
expect(seen).toEqual(['m1']);
161161

162-
app.off('messageCreate', handler as never);
162+
app.off('messageCreate', handler);
163163
runtime.emit('messageCreate', {
164164
receivedAt: Date.now(),
165165
message: {
@@ -172,7 +172,7 @@ describe('in-process app bridge', () => {
172172
});
173173
expect(seen).toEqual(['m1']);
174174

175-
const second = app.on('messageCreate', handler as never);
175+
const second = app.on('messageCreate', handler);
176176
unsub();
177177
second();
178178
await app.close();
@@ -236,7 +236,7 @@ describe('in-process app bridge', () => {
236236
capabilities: { events: ['ready', 'messageCreate'], actions: ['runRaw'] },
237237
});
238238

239-
app.off('ready', (() => undefined) as never);
239+
app.off('ready', (() => undefined));
240240
const h1 = (() => undefined) as never;
241241
const h2 = (() => undefined) as never;
242242
const unsub1 = app.on('ready', h1);
@@ -258,11 +258,11 @@ describe('in-process app bridge', () => {
258258
unsub1();
259259
unsub1();
260260
unsub2();
261-
const missingUnsub = app.on('messageCreate', (() => undefined) as never);
261+
const missingUnsub = app.on('messageCreate', (() => undefined));
262262
missingUnsub();
263-
app.off('messageCreate', (() => undefined) as never);
263+
app.off('messageCreate', (() => undefined));
264264

265-
expect(() => app.on('guildDelete', (() => undefined) as never)).toThrow(/not available/i);
265+
expect(() => app.on('guildDelete', (() => undefined))).toThrow(/not available/i);
266266
await app.close();
267267

268268
const afterClose = await app.raw('guilds.fetch', ['x']);

packages/shardwire/test/validation.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ describe('discord-first bridge validation', () => {
179179
connectBotBridge({
180180
url: 'http://example.com',
181181
secret: '',
182-
} as never),
182+
}),
183183
).toThrow(/url|secret/i);
184184
});
185185

@@ -655,7 +655,7 @@ describe('discord-first bridge validation', () => {
655655
});
656656

657657
await bot.ready();
658-
await expect(app.ready({ strict: true } as never)).rejects.toThrow(/requires `manifest`/);
658+
await expect(app.ready({ strict: true })).rejects.toThrow(/requires `manifest`/);
659659

660660
await app.close();
661661
await bot.close();

0 commit comments

Comments
 (0)