fix(update): make all downloads non-fatal and add CLI integration tests (1.1.5)

Author: nolrm

CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## [1.1.5] - 2026-06-29
+
+### Fixed
+- **`ck update` resilience (complete)** — ALL file downloads (commands, hooks, standards, types, scripts) are now non-fatal. Any single file failure logs a `⚠ Skipped` warning and the update continues. Previously only types and legacy scripts were graceful; a transient 400 on any command file still aborted the entire update and rolled back the backup.
+- **`ck update` skipped-file reporting** — spinner now shows `Files updated (N skipped — retry if issues persist)` when downloads were skipped, making partial updates visible.
+
+### Tests
+- **`update` unit tests** — added tests 20–21 verifying that a 400 on a command file download is non-fatal and logs a warning instead of aborting.
+- **CLI integration tests** — expanded `cli.test.js` from 9 to 18 numbered tests; now covers `ck update`, `ck check`, `ck analyze`, `ck note`, `ck run` at the CLI level, and verifies `ck update` exits cleanly when ContextKit is not installed.
+- **`download-manifest` test** — updated URL regex to match refactored `${base}` variable alongside original `${this.repoUrl}`.
+
 ## [1.1.4] - 2026-06-29
 
 ### Fixed

__tests__/commands/update.test.js

@@ -326,6 +326,62 @@ describe('UpdateCommand', () => {
     expect(logged).toContain('preserved');
   });
 
+  it('20. continues update when a command file download fails with 400', async () => {
+    const DownloadManager = require('../../lib/utils/download');
+    const realFs = require('fs-extra');
+
+    DownloadManager.mockImplementationOnce(() => ({
+      downloadFile: jest.fn().mockImplementation(async (url, dest) => {
+        if (url.includes('refactor.md')) {
+          throw new Error('Request failed with status code 400');
+        }
+        await realFs.ensureDir(path.dirname(dest));
+        await realFs.writeFile(dest, '# mocked download\n');
+      }),
+    }));
+
+    await fs.ensureDir('.contextkit');
+    await fs.writeFile('.contextkit/config.yml', baseConfig);
+
+    const update = getUpdateModule();
+    await expect(update({ force: true })).resolves.not.toThrow();
+
+    const logged = console.log.mock.calls.flat().join(' ');
+    expect(logged).toContain('Skipped');
+    expect(logged).toContain('refactor.md');
+  });
+
+  it('21. reports skipped count in success message when files are skipped', async () => {
+    const DownloadManager = require('../../lib/utils/download');
+    const realFs = require('fs-extra');
+    const ora = require('ora');
+
+    let succeedMessage = '';
+    jest.spyOn(ora(), 'succeed').mockImplementation((msg) => {
+      succeedMessage = msg || '';
+    });
+
+    DownloadManager.mockImplementationOnce(() => ({
+      downloadFile: jest.fn().mockImplementation(async (url, dest) => {
+        if (url.includes('typescript-strict.json')) {
+          throw new Error('Request failed with status code 400');
+        }
+        await realFs.ensureDir(path.dirname(dest));
+        await realFs.writeFile(dest, '# mocked download\n');
+      }),
+    }));
+
+    await fs.ensureDir('.contextkit');
+    await fs.writeFile('.contextkit/config.yml', baseConfig);
+
+    const update = getUpdateModule();
+    await expect(update({ force: true })).resolves.not.toThrow();
+
+    const logged = console.log.mock.calls.flat().join(' ');
+    expect(logged).toContain('Skipped');
+    expect(logged).toContain('typescript-strict.json');
+  });
+
   it('11. version comparison works correctly', async () => {
     // Access the class to test isNewerVersion
     delete require.cache[require.resolve('../../lib/commands/update')];

__tests__/integration/cli.test.js

@@ -1,33 +1,48 @@
 const { execSync } = require('child_process');
 const path = require('path');
+const fs = require('fs-extra');
+const os = require('os');
 const packageJson = require('../../package.json');
 
 describe('CLI Integration Tests', () => {
   const cliPath = path.join(__dirname, '../../bin/contextkit.js');
+  let tmpDir;
+
+  beforeEach(async () => {
+    tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'ck-cli-'));
+  });
+
+  afterEach(async () => {
+    await fs.remove(tmpDir);
+  });
 
   describe('version command', () => {
-    test('should show version', () => {
+    test('1. --version shows current package version', () => {
       const result = execSync(`node "${cliPath}" --version`, { encoding: 'utf8' });
       expect(result.trim()).toBe(packageJson.version);
     });
 
-    test('should show version with -v flag', () => {
+    test('2. -v flag shows current package version', () => {
       const result = execSync(`node "${cliPath}" -v`, { encoding: 'utf8' });
       expect(result.trim()).toBe(packageJson.version);
     });
   });
 
   describe('help command', () => {
-    test('should show help', () => {
+    test('3. --help shows all core commands', () => {
       const result = execSync(`node "${cliPath}" --help`, { encoding: 'utf8' });
       expect(result).toContain('Context Engineering for AI Development');
       expect(result).toContain('Commands:');
       expect(result).toContain('install');
       expect(result).toContain('status');
       expect(result).toContain('update');
+      expect(result).toContain('analyze');
+      expect(result).toContain('check');
+      expect(result).toContain('note');
+      expect(result).toContain('run');
     });
 
-    test('should show platform commands in help', () => {
+    test('4. --help shows all platform commands', () => {
       const result = execSync(`node "${cliPath}" --help`, { encoding: 'utf8' });
       expect(result).toContain('windsurf');
       expect(result).toContain('codex');
@@ -38,26 +53,94 @@ describe('CLI Integration Tests', () => {
       expect(result).toContain('aider');
     });
 
-    test('should show help for install command', () => {
+    test('5. install --help shows install options', () => {
       const result = execSync(`node "${cliPath}" install --help`, { encoding: 'utf8' });
       expect(result).toContain('Initialize ContextKit in the current project directory');
       expect(result).toContain('--no-hooks');
       expect(result).toContain('--non-interactive');
     });
+
+    test('6. update --help shows update description and --force option', () => {
+      const result = execSync(`node "${cliPath}" update --help`, { encoding: 'utf8' });
+      expect(result).toContain('Update to latest version');
+      expect(result).toContain('--force');
+    });
+
+    test('7. analyze --help shows analyze description and options', () => {
+      const result = execSync(`node "${cliPath}" analyze --help`, { encoding: 'utf8' });
+      expect(result).toContain('Analyze project');
+      expect(result).toContain('--ai');
+      expect(result).toContain('--scope');
+    });
+
+    test('8. check --help shows check description and options', () => {
+      const result = execSync(`node "${cliPath}" check --help`, { encoding: 'utf8' });
+      expect(result).toContain('Validate ContextKit installation');
+      expect(result).toContain('--strict');
+      expect(result).toContain('--verbose');
+    });
+
+    test('9. note --help shows note description and options', () => {
+      const result = execSync(`node "${cliPath}" note --help`, { encoding: 'utf8' });
+      expect(result).toContain('Add a note');
+      expect(result).toContain('--priority');
+      expect(result).toContain('--category');
+    });
+
+    test('10. run --help shows run description and options', () => {
+      const result = execSync(`node "${cliPath}" run --help`, { encoding: 'utf8' });
+      expect(result).toContain('Run a workflow');
+      expect(result).toContain('--interactive');
+    });
   });
 
   describe('status command', () => {
-    test('should run status command', () => {
+    test('11. status runs without crashing (installed or not)', () => {
       const result = execSync(`node "${cliPath}" status`, { encoding: 'utf8' });
-      // CI has no .contextkit/config.yml; local dev has full install
       const notInstalled = result.includes('ContextKit is not installed');
       const installed = result.includes('ContextKit Status') && result.includes('Installation:');
       expect(notInstalled || installed).toBe(true);
     });
+
+    test('12. status reports not installed when run from empty directory', () => {
+      const result = execSync(`node "${cliPath}" status`, {
+        encoding: 'utf8',
+        cwd: tmpDir,
+      });
+      expect(result).toContain('not installed');
+    });
+  });
+
+  describe('update command', () => {
+    test('13. update exits cleanly with no .contextkit (not installed)', () => {
+      const result = execSync(`node "${cliPath}" update`, {
+        encoding: 'utf8',
+        cwd: tmpDir,
+      });
+      expect(result).toContain('No ContextKit installation found');
+    });
+
+    test('14. update suggests install command when not installed', () => {
+      const result = execSync(`node "${cliPath}" update`, {
+        encoding: 'utf8',
+        cwd: tmpDir,
+      });
+      expect(result).toContain('contextkit install');
+    });
+  });
+
+  describe('check command', () => {
+    test('15. check exits cleanly with no .contextkit (not installed)', () => {
+      const result = execSync(`node "${cliPath}" check`, {
+        encoding: 'utf8',
+        cwd: tmpDir,
+      });
+      expect(result).toMatch(/not installed|No ContextKit/i);
+    });
   });
 
   describe('error handling', () => {
-    test('should print error and exit non-zero for unknown commands', () => {
+    test('16. unknown command prints error and exits non-zero', () => {
       let threw = false;
       try {
         execSync(`node "${cliPath}" unknown-command`, { encoding: 'utf8' });
@@ -73,16 +156,15 @@ describe('CLI Integration Tests', () => {
   });
 
   describe('update-notifier', () => {
-    test('CLI exits with code 0 and notifier does not break output', () => {
-      // update-notifier is suppressed in CI (CI=true env var); verify the CLI still runs cleanly
+    test('17. CLI exits with code 0 and notifier does not break output', () => {
       const result = execSync(`node "${cliPath}" --version`, {
         encoding: 'utf8',
         env: { ...process.env, CI: 'true' },
       });
       expect(result.trim()).toBe(packageJson.version);
     });
 
-    test('CLI --help output is unaffected by notifier', () => {
+    test('18. --help output is unaffected by notifier', () => {
       const result = execSync(`node "${cliPath}" --help`, {
         encoding: 'utf8',
         env: { ...process.env, CI: 'true' },

__tests__/integration/download-manifest.test.js

@@ -11,8 +11,8 @@ const ROOT = path.resolve(__dirname, '..', '..');
 function extractDownloadPaths(sourceFile) {
   const content = fs.readFileSync(sourceFile, 'utf8');
   const paths = [];
-  // Match: `${this.repoUrl}/some/path`
-  const regex = /\$\{this\.repoUrl\}\/([\w./-]+)/g;
+  // Match: `${this.repoUrl}/some/path` or `${base}/some/path`
+  const regex = /\$\{(?:this\.repoUrl|base)\}\/([\w./-]+)/g;
   let match;
   while ((match = regex.exec(content)) !== null) {
     paths.push(match[1]);