ENDF/B-VIII.1 Discrete primary gamma format discrepancy handling in ACER#391
Merged
whaeck merged 6 commits intofeature/llvm-flangfrom Mar 18, 2026
Merged
Conversation
…Pt190 eval fixing author from mac default
whaeck
reviewed
Mar 3, 2026
| integer::mt103,mt104,mt105,mt106,mt107 | ||
| integer::mpmin,mpmax,mdmin,mdmax,mtmin,mtmax,m3min,m3max,m4min,m4max | ||
|
|
||
| !-- Modification Jan 2026 by A. Lewis |
Member
There was a problem hiding this comment.
I think you can remove the modification comments (begin and end)
Contributor
Author
There was a problem hiding this comment.
they've all been removed
whaeck
reviewed
Mar 3, 2026
| !-- is from ENDF-8.1. This will hopefully be resolved before | ||
| !-- the next ENDF release. | ||
| if (law.eq.1.and.ep.lt.zero) then | ||
| if (nlib.eq.0.and.nver.eq.8.and.lrel.eq.1) then |
Member
There was a problem hiding this comment.
Maybe add a warning for the user to check the format to be sure it is done correctly for non-ENDF evaluations?
Contributor
Author
There was a problem hiding this comment.
I added a message in the else block that the gammas are assumed to follow the JENDL format
Member
|
I updated the release notes in the develop branch. You should pull that in, and update the release notes for this development. |
whaeck
previously approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix in
ACERfor the ENDF/B-VIII.1 format discrepancy for discrete primary gammas in File 6 - the energy listed is the outgoing gamma energy. Previous JENDL releases listed the binding energy, and that is what NJOY2016 expected. This change gathers the library and release number and for ENDF/B-VIII.1 only, converts the energy to what NJOY2016 expects. It also adds a new test case (87) that uses the ENDF/B-VIII.1 Pt190 evaluation.The library and release number is checked because it is likely that the next release of ENDF/B will resolve this issue.
The corresponding manual change merge request is here
Note:
This commit doesn't touch
HEATR- that is a separate problem.