fix(build): simplify package build pipeline and fix windows pipeline issue (#2458)

markwhitfeld · claude · web-flow · commit 9f3451d3b623 · 2026-06-18T12:00:50.000Z
* build: stop emitting .d.ts for schematics

Schematics ship as Angular CLI generators executed as runtime JavaScript;
their TypeScript types are not part of the public API surface. Up to now
the schematics tsconfig was emitting per-source `.d.ts` files, which the
postbuild had to strip from the build output before publish.

Flip declaration to false in both tsconfig.schematics.json files so the
files are never emitted in the first place. Net effect on the published
tarball is unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;

* build: drop rollup-based .d.ts flattening postbuild

ng-packagr 20.x already emits a single flattened `.d.ts` per entry point,
so `rollup-plugin-dts` has nothing left to bundle (running it against the
current output only reorders named-import members on one line). With the
previous commit stopping schematics `.d.ts` emission, `remove-dts.mjs`
also has nothing left to clean up.

The remove-dts step additionally carried a Windows-only path-separator
bug: `path.resolve` returns backslash paths while `glob.sync` returns
forward-slash paths, so the entry-point filter never matched on Windows
and every flattened entry-point d.ts was deleted along with the rest.
The bug went undetected because publishes ran from Linux CI.

Remove `yarn rollup -c rollup.config.mjs &amp;&amp; node ./build/remove-dts.mjs`
from the postbuild script, delete the rollup config and the two helper
scripts, and drop the now-unused rollup / rollup-plugin-dts devDeps.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;

* build: exclude jest snapshot artifacts from schematics output

The storage-plugin schematics source contains a jest snapshot at
`schematics/src/ng-generate/__snapshots__/keys-migration.spec.ts.snap`
that lives alongside the spec file for the snapshot mechanism. The
file-copy step in build-schematics.mjs only filtered out `.ts` source
files, so the snapshot artifact was being copied into the publishable
output and shipped on npm.

Filter `.snap` files and `__snapshots__` directories out of the copy.
Store schematics output is unaffected (its source has no jest snapshots).

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;

* chore: update changelog

---------

Co-authored-by: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -31,7 +31,8 @@ $ npm install @ngxs/store@dev
 - Fix(storage-plugin): Guard against environments that do not provide `ngServerMode` [#2400](https://github.com/ngxs/store/pull/2400)
 - Fix(storage-plugin): Improve dependency ranges for security fixes [#2404](https://github.com/ngxs/store/pull/2404)
 - Fix(storage-plugin): Treat missing version key as 0 when matching migrations [#2422](https://github.com/ngxs/store/pull/2422)
-- Build: use trusted npm publishing for provenance signed builds [#2454](https://github.com/ngxs/store/pull/2454)
+- Build: Simplify package build pipeline and fix windows pipeline issue [#2458](https://github.com/ngxs/store/pull/2458)
+- Build: Use trusted npm publishing for provenance signed builds [#2454](https://github.com/ngxs/store/pull/2454)
 
 ### 21.0.0 2025-12-17
 
diff --git a/build/collect-dts.mjs b/build/collect-dts.mjs
diff --git a/build/remove-dts.mjs b/build/remove-dts.mjs
diff --git a/package.json b/package.json
@@ -73,7 +73,7 @@
     "serve:integration:ssr": "node dist-integration/server/server.mjs",
     "// - BUILDING": "Run Apps in dev and with packaged modules",
     "build": "yarn build:packages",
-    "postbuild": "yarn rollup -c rollup.config.mjs && node ./build/remove-dts.mjs && node ./build/copy-license.mjs",
+    "postbuild": "node ./build/copy-license.mjs",
     "build:packages": "yarn nx run-many --target=build --all && ts-node tools/set-metadata",
     "// - INTEGRATION BUILDS": "#requires yarn build",
     "build:integration": "nx build integration -c production",
@@ -159,8 +159,6 @@
     "npm-run-all": "^4.1.5",
     "nx": "22.7.5",
     "prettier": "3.2.5",
-    "rollup": "^4",
-    "rollup-plugin-dts": "^6.1.0",
     "rxjs": "^7.4.0",
     "serve": "^14.2.5",
     "start-server-and-test": "^3.0.11",
diff --git a/packages/storage-plugin/tsconfig.schematics.json b/packages/storage-plugin/tsconfig.schematics.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": ["es2018", "dom"],
-    "declaration": true,
+    "declaration": false,
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
diff --git a/packages/store/tsconfig.schematics.json b/packages/store/tsconfig.schematics.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": ["es2018", "dom"],
-    "declaration": true,
+    "declaration": false,
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
diff --git a/rollup.config.mjs b/rollup.config.mjs
diff --git a/tools/build-schematics.mjs b/tools/build-schematics.mjs
@@ -1,5 +1,5 @@
 import yargs from 'yargs';
-import { join } from 'path';
+import { basename, join } from 'path';
 import { execSync } from 'child_process';
 import fse from 'fs-extra';
 
@@ -21,10 +21,15 @@ console.log(`Running "${cmd}"`);
 execSync(cmd, { stdio: 'inherit' });
 
 fse.copySync(schematicsSrc, join(distPath, 'schematics', 'src'), src => {
-  // skip not compiled files
+  // TypeScript sources are compiled separately by tsc above.
   if (src.endsWith('.ts')) {
     return false;
   }
+  // Jest snapshot artifacts live alongside spec files in source but must
+  // never ship in the published package.
+  if (src.endsWith('.snap') || basename(src) === '__snapshots__') {
+    return false;
+  }
   return true;
 });
 
diff --git a/yarn.lock b/yarn.lock
@@ -9301,7 +9301,7 @@ hasown@2.0.2, hasown@^2.0.2:
   dependencies:
     function-bind "^1.1.2"
 
-hasown@^2.0.3, hasown@^2.0.4:
+hasown@^2.0.3:
   version "2.0.4"
   resolved "https://registry.npmjs.org/hasown/-/hasown-2.0.4.tgz#8c62d8cb90beb2aad5d0a5b67581ad9854c3f003"
   integrity sha512-T2UbfbBEF32wiepXIsMlTW9+dDYC6wMh/t/vYA4tuOMKqWz/n3vr1NFSxQiyP+zk2mXsoMA/i/7qV6LKut1t1A==
@@ -11772,7 +11772,7 @@ mime-types@2.1.18:
   dependencies:
     mime-db "~1.33.0"
 
-mime-types@2.1.35, mime-types@^2.1.12, mime-types@^2.1.27, mime-types@^2.1.31, mime-types@^2.1.35, mime-types@~2.1.17, mime-types@~2.1.19, mime-types@~2.1.24, mime-types@~2.1.34:
+mime-types@2.1.35, mime-types@^2.1.12, mime-types@^2.1.27, mime-types@^2.1.31, mime-types@~2.1.17, mime-types@~2.1.19, mime-types@~2.1.24, mime-types@~2.1.34:
   version "2.1.35"
   resolved "https://registry.npmjs.org/mime-types/-/mime-types-2.1.35.tgz#381a871b62a734450660ae3deee44813f70d959a"
   integrity sha512-ZDY+bPm5zTTF+YpCrAU9nK0UgICYPT0QtT1NZWFv4s++TNkcgVaT0g6+4R2uI4MjQjzysHB1zxuWL50hzaeXiw==
@@ -13869,7 +13869,7 @@ rimraf@^3.0.2:
   dependencies:
     glob "^7.1.3"
 
-rollup-plugin-dts@^6.1.0, rollup-plugin-dts@^6.2.0:
+rollup-plugin-dts@^6.2.0:
   version "6.2.1"
   resolved "https://registry.npmjs.org/rollup-plugin-dts/-/rollup-plugin-dts-6.2.1.tgz#120a40734f740115da44931d7915a370fe420701"
   integrity sha512-sR3CxYUl7i2CHa0O7bA45mCrgADyAQ0tVtGSqi3yvH28M+eg1+g5d7kQ9hLvEz5dorK3XVsH5L2jwHLQf72DzA==
@@ -13912,7 +13912,7 @@ rollup@4.59.0:
     "@rollup/rollup-win32-x64-msvc" "4.59.0"
     fsevents "~2.3.2"
 
-rollup@^4, rollup@^4.24.0:
+rollup@^4.24.0:
   version "4.61.1"
   resolved "https://registry.npmjs.org/rollup/-/rollup-4.61.1.tgz#4a053204912e9083e51cb3a0bf02ffdc397264fb"
   integrity sha512-I4KW6iuRpuu2uHBLraZ1wNZe0DP7lnRha+VJ9tNaYVaVgKhW0aI3h4RYnoRPeql0flHm/Co55b7snEDcOfOJrA==
