test(conda): keep is_gha() gate on env-creation block

Restore the is_gha() guard on the construct_conda_yml conda env-creation
block that was dropped in ac61194. The block creates a real conda env
under ~/miniforge3/envs/testenv and is intentionally GHA-only — running
it on a developer machine leaves persistent state behind, and the
test's own `condaenv_exists()` cleanup misses orphaned env directories,
so subsequent runs fail with `prefix already exists`. is_gha() is the
right gate here because the test is genuinely targeting the GHA
environment (where setup-miniconda provides conda on PATH and the
runner is fresh).

Update the NEWS bullet to reflect that is_gha() is retained for this
single test; everywhere else the gates are now host-specific
skip_if_offline().

Author: HDash

NEWS.md

@@ -62,11 +62,17 @@ and vignettes.
 * Forward the `ncpus` input to `grimbough/bioc-actions/setup-bioc@v1` (as
   its `Ncpus` input) so non-Linux R installs use the configured parallel
   job count instead of the action's default of 3.
-* Tests: replace `if(!is_gha()) skip_if_offline()` gates with
-  host-specific `skip_if_offline(host=...)` calls
+* Tests: replace `is_gha()` gates that were guarding internet access
+  with host-specific `skip_if_offline(host=...)` calls
   (`bioconductor.org`, `github.com`, `raw.githubusercontent.com`,
-  `ghcr.io`, `conda.anaconda.org`) so individual tests skip when their
-  actual remote is unreachable rather than relying on a GHA escape hatch.
+  `ghcr.io`) so individual tests skip when their actual remote is
+  unreachable. This includes the `get_description` Bioc-repo block,
+  which previously gated on `is_gha() | is_rstudio()` to dodge CRAN
+  flakiness (#65); it now skips on `bioconductor.org` instead.
+  `is_gha()` is retained only for the `construct_conda_yml`
+  env-creation block, where the test is genuinely GHA-only (creates
+  and leaves a conda env behind, so should not run on developer
+  machines).
 
 # rworkflows 1.0.11
 

tests/testthat/test-construct_conda_yml.R

@@ -31,8 +31,9 @@ test_that("construct_conda_yml works", {
 
   #### Construct an actual conda env ####
   if("reticulate" %in% rownames(installed.packages()) &&
-     conda_installed() &&
-     .Platform$OS.type != "windows"){
+     conda_installed() && 
+     is_gha() &&
+     .Platform$OS.type != "windows"){ 
     envname <- "testenv"
     if(condaenv_exists(envname)){
       reticulate::conda_remove(envname = envname)