BUG: get_object_vars in ObjectAccess::initializePropertyGetterCache only takes initialized properties into account

[sorenmalling]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

With a class containing the follow properties

    #[ORM\ManyToOne]
    #[ORM\JoinColumn(nullable: true)]
    public ?Identity $identity = null;

    #[ORM\ManyToOne(inversedBy: 'people')]
    #[ORM\JoinColumn(nullable: false)]
    public Network $network;

only the property $identity is returned in get_object_vars($subject)

https://github.com/neos/flow-development-collection/blob/9.2/Neos.Utility.ObjectHandling/Classes/ObjectAccess.php#L194-L196

This means, that validation is breaking, as the validator can't access non-initialized properties.

This is intended behavior of that function described in the note on php.net
https://www.php.net/manual/en/function.get-object-vars.php

Expected Behavior

All public properties should be seen by the ObjectAccess.

Solvable with ReflectionClass

Changing this to using the ReflectionClass functionality we can get all public properties

        $properties = array_map(fn(\ReflectionProperty $property) => $property->getName(), (new \ReflectionClass($subject))->getProperties(\ReflectionProperty::IS_PUBLIC));

        if (in_array($propertyName, $properties)) {
            self::$propertyGetterCache[$cacheIdentifier]['publicProperty'] = $propertyName;
        }

Steps To Reproduce

No response

Environment

- Flow: 9.1.1
- PHP: 8.5

Anything else?

No response

[sorenmalling]

Found while doing the following (for context)

From a NetworkCommand::enrollCommand method

    public function enrollCommand(Network $network, string $emailAddress)
    {
        $identity = $this->identities->findByEmailAddress(EmailAddress::fromString($emailAddress));
        if ($identity === null) {
            $identity = new Identity();
            $identity->emailAddress = $emailAddress;
            $this->identities->add($identity);
        }

        $network->enroll($identity);
        $this->networks->update($network);
    }

and a method inside the Network entity

    public function enroll(Identity $identity, Role $role = Role::Member)
    {
        if (
            $this->people->matching(
                Criteria::create()->andWhere(
                    Criteria::expr()->eq('identity', $identity)
                )
            )->isEmpty()
        ) {
            $person = Person::fromIdentity($identity);
            $person->role = $role;
            $person->network = $this;
            $this->people->add($person);
        }
    }