diff --git a/changes/914.changed b/changes/914.changed new file mode 100644 index 000000000..b873c3bdd --- /dev/null +++ b/changes/914.changed @@ -0,0 +1 @@ +Removes conditional UI views for when compliance, intended, and backup settings are disabled. diff --git a/nautobot_golden_config/navigation.py b/nautobot_golden_config/navigation.py index 0b3aa46d2..7090f27a0 100644 --- a/nautobot_golden_config/navigation.py +++ b/nautobot_golden_config/navigation.py @@ -2,129 +2,91 @@ from nautobot.apps.ui import NavMenuAddButton, NavMenuGroup, NavMenuItem, NavMenuTab -from nautobot_golden_config.utilities.constant import ENABLE_BACKUP, ENABLE_COMPLIANCE, ENABLE_PLAN - -items_operate = [ +items_operate = ( NavMenuItem( link="plugins:nautobot_golden_config:goldenconfig_list", name="Config Overview", permissions=["nautobot_golden_config.view_goldenconfig"], - ) -] - -items_setup = [] - -if ENABLE_COMPLIANCE: - items_operate.append( - NavMenuItem( - link="plugins:nautobot_golden_config:configcompliance_list", - name="Config Compliance", - permissions=["nautobot_golden_config.view_configcompliance"], - ) - ) - -if ENABLE_COMPLIANCE: - items_setup.append( - NavMenuItem( - link="plugins:nautobot_golden_config:compliancerule_list", - name="Compliance Rules", - permissions=["nautobot_golden_config.view_compliancerule"], - buttons=( - NavMenuAddButton( - link="plugins:nautobot_golden_config:compliancerule_add", - permissions=["nautobot_golden_config.add_compliancerule"], - ), + ), + NavMenuItem( + link="plugins:nautobot_golden_config:configcompliance_list", + name="Config Compliance", + permissions=["nautobot_golden_config.view_configcompliance"], + ), + NavMenuItem( + link="plugins:nautobot_golden_config:configcompliance_overview", + name="Compliance Report", + permissions=["nautobot_golden_config.view_configcompliance"], + ), + NavMenuItem( + link="plugins:nautobot_golden_config:configplan_list", + name="Config Plans", + permissions=["nautobot_golden_config.view_configplan"], + buttons=( + NavMenuAddButton( + link="plugins:nautobot_golden_config:configplan_add", + permissions=["nautobot_golden_config.add_configplan"], ), - ) - ) + ), + ), +) -if ENABLE_COMPLIANCE: - items_setup.append( - NavMenuItem( - link="plugins:nautobot_golden_config:compliancefeature_list", - name="Compliance Features", - permissions=["nautobot_golden_config.view_compliancefeature"], - buttons=( - NavMenuAddButton( - link="plugins:nautobot_golden_config:compliancefeature_add", - permissions=["nautobot_golden_config.add_compliancefeature"], - ), +items_setup = ( + NavMenuItem( + link="plugins:nautobot_golden_config:compliancerule_list", + name="Compliance Rules", + permissions=["nautobot_golden_config.view_compliancerule"], + buttons=( + NavMenuAddButton( + link="plugins:nautobot_golden_config:compliancerule_add", + permissions=["nautobot_golden_config.add_compliancerule"], ), - ) - ) - - -if ENABLE_COMPLIANCE: - items_operate.append( - NavMenuItem( - link="plugins:nautobot_golden_config:configcompliance_overview", - name="Compliance Report", - permissions=["nautobot_golden_config.view_configcompliance"], - ) - ) - -if ENABLE_PLAN: - items_operate.append( - NavMenuItem( - link="plugins:nautobot_golden_config:configplan_list", - name="Config Plans", - permissions=["nautobot_golden_config.view_configplan"], - buttons=( - NavMenuAddButton( - link="plugins:nautobot_golden_config:configplan_add", - permissions=["nautobot_golden_config.add_configplan"], - ), + ), + ), + NavMenuItem( + link="plugins:nautobot_golden_config:compliancefeature_list", + name="Compliance Features", + permissions=["nautobot_golden_config.view_compliancefeature"], + buttons=( + NavMenuAddButton( + link="plugins:nautobot_golden_config:compliancefeature_add", + permissions=["nautobot_golden_config.add_compliancefeature"], ), - ) - ) - -if ENABLE_BACKUP: - items_setup.append( - NavMenuItem( - link="plugins:nautobot_golden_config:configremove_list", - name="Config Removals", - permissions=["nautobot_golden_config.view_configremove"], - buttons=( - NavMenuAddButton( - link="plugins:nautobot_golden_config:configremove_add", - permissions=["nautobot_golden_config.add_configremove"], - ), + ), + ), + NavMenuItem( + link="plugins:nautobot_golden_config:configremove_list", + name="Config Removals", + permissions=["nautobot_golden_config.view_configremove"], + buttons=( + NavMenuAddButton( + link="plugins:nautobot_golden_config:configremove_add", + permissions=["nautobot_golden_config.add_configremove"], ), - ) - ) - -if ENABLE_BACKUP: - items_setup.append( - NavMenuItem( - link="plugins:nautobot_golden_config:configreplace_list", - name="Config Replacements", - permissions=["nautobot_golden_config.view_configreplace"], - buttons=( - NavMenuAddButton( - link="plugins:nautobot_golden_config:configreplace_add", - permissions=["nautobot_golden_config.add_configreplace"], - ), + ), + ), + NavMenuItem( + link="plugins:nautobot_golden_config:configreplace_list", + name="Config Replacements", + permissions=["nautobot_golden_config.view_configreplace"], + buttons=( + NavMenuAddButton( + link="plugins:nautobot_golden_config:configreplace_add", + permissions=["nautobot_golden_config.add_configreplace"], ), - ) - ) - - -if ENABLE_COMPLIANCE: - items_setup.append( - NavMenuItem( - link="plugins:nautobot_golden_config:remediationsetting_list", - name="Remediation Settings", - permissions=["nautobot_golden_config.view_remediationsetting"], - buttons=( - NavMenuAddButton( - link="plugins:nautobot_golden_config:remediationsetting_add", - permissions=["nautobot_golden_config.add_remediationsetting"], - ), + ), + ), + NavMenuItem( + link="plugins:nautobot_golden_config:remediationsetting_list", + name="Remediation Settings", + permissions=["nautobot_golden_config.view_remediationsetting"], + buttons=( + NavMenuAddButton( + link="plugins:nautobot_golden_config:remediationsetting_add", + permissions=["nautobot_golden_config.add_remediationsetting"], ), - ) - ) - -items_setup.append( + ), + ), NavMenuItem( link="plugins:nautobot_golden_config:goldenconfigsetting_list", name="Golden Config Settings", @@ -138,14 +100,13 @@ ), ) - menu_items = ( NavMenuTab( name="Golden Config", weight=1000, groups=( - NavMenuGroup(name="Manage", weight=100, items=tuple(items_operate)), - NavMenuGroup(name="Setup", weight=100, items=tuple(items_setup)), + NavMenuGroup(name="Manage", weight=100, items=items_operate), + NavMenuGroup(name="Setup", weight=100, items=items_setup), NavMenuGroup( name="Tools", weight=300, diff --git a/nautobot_golden_config/templates/nautobot_golden_config/configcompliance_list.html b/nautobot_golden_config/templates/nautobot_golden_config/configcompliance_list.html index c2e6afcc2..7ed57f2d2 100644 --- a/nautobot_golden_config/templates/nautobot_golden_config/configcompliance_list.html +++ b/nautobot_golden_config/templates/nautobot_golden_config/configcompliance_list.html @@ -7,9 +7,7 @@ Execute
{% endblock %} \ No newline at end of file diff --git a/nautobot_golden_config/templates/nautobot_golden_config/configcompliance_overview.html b/nautobot_golden_config/templates/nautobot_golden_config/configcompliance_overview.html index 8d6a13253..51bdd0688 100644 --- a/nautobot_golden_config/templates/nautobot_golden_config/configcompliance_overview.html +++ b/nautobot_golden_config/templates/nautobot_golden_config/configcompliance_overview.html @@ -16,9 +16,7 @@ Execute {% endblock %} diff --git a/nautobot_golden_config/templates/nautobot_golden_config/content_template.html b/nautobot_golden_config/templates/nautobot_golden_config/content_template.html index 7ebd6fbe2..40462f415 100644 --- a/nautobot_golden_config/templates/nautobot_golden_config/content_template.html +++ b/nautobot_golden_config/templates/nautobot_golden_config/content_template.html @@ -1,4 +1,3 @@ -{% if compliance %}