setxattr/lsetxattr/fsetxattr: fail on read-only filesystem

Francesco Lavra · Francesco Lavra · commit d3df11ef3835 · 2026-04-19T18:41:43.000+02:00
These syscalls change the extended attributes in file metadata, and as such
should not be allowed on read-only filesystems.
diff --git a/src/unix/filesystem.c b/src/unix/filesystem.c
@@ -655,6 +655,8 @@ static sysreturn xattr_check(filesystem fs, const char *name, sstring *name_ss)
 static sysreturn setxattr_internal(filesystem fs, tuple n, const char *name,
                                    const void *val, u64 size, int flags)
 {
+    if (fs->ro)
+        return -EROFS;
     sstring attr_name;
     sysreturn rv = xattr_check(fs, name, &attr_name);
     if (rv)

Original file line number	Diff line number	Diff line change
`@@ -655,6 +655,8 @@ static sysreturn xattr_check(filesystem fs, const char name, sstring name_ss)`
`655`	`655`	`static sysreturn setxattr_internal(filesystem fs, tuple n, const char *name,`
`656`	`656`	`const void *val, u64 size, int flags)`
`657`	`657`	`{`
	`658`	`+ if (fs->ro)`
	`659`	`+ return -EROFS;`
`658`	`660`	`sstring attr_name;`
`659`	`661`	`sysreturn rv = xattr_check(fs, name, &attr_name);`
`660`	`662`	`if (rv)`