chore: Update Go to 1.26.0 and golangci-lint to v2.10.0 (#114)

Co-authored-by: Leo Antoli <lantoli@users.noreply.github.com>

Author: lantoli

.github/workflows/code-health.yml

@@ -48,7 +48,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20
         with:
-          version: v2.8.0 # Also update GOLANGCI_VERSION variable in Makefile when updating this version
+          version: v2.10.0 # Also update GOLANGCI_VERSION variable in Makefile when updating this version
       - name: actionlint
         run: |
           make tools
@@ -57,3 +57,25 @@ jobs:
         shell: bash
       - name: shellcheck
         uses: bewuethr/shellcheck-action@80bac2daa9fcf95d648200a793d00060857e6dc4
+
+  check-go-files:
+      runs-on: ubuntu-latest
+      permissions: {}
+      steps:
+        - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        - uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5    
+          with:
+            go-version-file: 'go.mod'  
+        - run: go mod tidy
+        - run: go fix ./...
+        - name: Find mutations
+          id: self_mutation
+          run: |-
+            git add .
+            git diff --staged --patch --exit-code > doc.repo.patch || echo "self_mutation_happened=true" >> "${GITHUB_OUTPUT}"
+        - name: Fail build on mutation
+          if: steps.self_mutation.outputs.self_mutation_happened
+          run: |-
+            echo "::error::Files were changed. Make sure to run 'go mod tidy' and 'go fix ./...'"
+            cat doc.repo.patch
+            exit 1

Makefile

@@ -4,7 +4,7 @@ CLI_DESTINATION=./bin/$(CLI_BINARY_NAME)
 MANIFEST_FILE?=./bin/manifest.yml
 WIN_MANIFEST_FILE?=./bin/manifest.windows.yml
 
-GOLANGCI_VERSION=v2.8.0 # Also update golangci-lint GH action in code-health.yml when updating this version
+GOLANGCI_VERSION=v2.10.0 # Also update golangci-lint GH action in code-health.yml when updating this version
 
 .PHONY: build 
 build: ## Generate the binary in ./bin

go.mod

@@ -1,6 +1,6 @@
 module github.com/mongodb-labs/atlas-cli-plugin-terraform
 
-go 1.25.7
+go 1.26.0
 
 require (
 	github.com/fsnotify/fsnotify v1.9.0

internal/cli/clu2adv/clu2adv.go

@@ -3,7 +3,7 @@ package clu2adv
 import (
 	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/cli"
 	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/convert"
-	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/flag"
+	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/flags"
 	"github.com/spf13/afero"
 	"github.com/spf13/cobra"
 )
@@ -29,7 +29,7 @@ func Builder() *cobra.Command {
 		RunE:    o.RunE,
 	}
 	cli.SetupCommonFlags(cmd, &o.BaseOpts)
-	cmd.Flags().BoolVarP(&o.includeMoved, flag.IncludeMoved, flag.IncludeMovedShort, false,
+	cmd.Flags().BoolVarP(&o.includeMoved, flags.IncludeMoved, flags.IncludeMovedShort, false,
 		"include moved blocks in the output file")
 	return cmd
 }

internal/cli/common.go

@@ -6,7 +6,7 @@ import (
 
 	"github.com/fsnotify/fsnotify"
 	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/file"
-	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/flag"
+	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/flags"
 	"github.com/spf13/afero"
 	"github.com/spf13/cobra"
 )
@@ -119,12 +119,12 @@ func (o *BaseOpts) waitForFileEvent(watcher *fsnotify.Watcher) error {
 
 // SetupCommonFlags sets up the common flags used by all commands.
 func SetupCommonFlags(cmd *cobra.Command, opts *BaseOpts) {
-	cmd.Flags().StringVarP(&opts.File, flag.File, flag.FileShort, "", "input file")
-	_ = cmd.MarkFlagRequired(flag.File)
-	cmd.Flags().StringVarP(&opts.Output, flag.Output, flag.OutputShort, "", "output file")
-	_ = cmd.MarkFlagRequired(flag.Output)
-	cmd.Flags().BoolVarP(&opts.ReplaceOutput, flag.ReplaceOutput, flag.ReplaceOutputShort, false,
+	cmd.Flags().StringVarP(&opts.File, flags.File, flags.FileShort, "", "input file")
+	_ = cmd.MarkFlagRequired(flags.File)
+	cmd.Flags().StringVarP(&opts.Output, flags.Output, flags.OutputShort, "", "output file")
+	_ = cmd.MarkFlagRequired(flags.Output)
+	cmd.Flags().BoolVarP(&opts.ReplaceOutput, flags.ReplaceOutput, flags.ReplaceOutputShort, false,
 		"replace output file if exists")
-	cmd.Flags().BoolVarP(&opts.Watch, flag.Watch, flag.WatchShort, false,
+	cmd.Flags().BoolVarP(&opts.Watch, flags.Watch, flags.WatchShort, false,
 		"keeps the plugin running and watches the input file for changes")
 }

internal/flag/flags.go internal/flags/flags.gointernal/flag/flags.go renamed to internal/flags/flags.go

@@ -1,4 +1,4 @@
-package flag
+package flags
 
 const (
 	File               = "file"

test/e2e/e2e_helper.go

@@ -2,6 +2,7 @@ package e2e
 
 import (
 	"context"
+	"maps"
 	"os"
 	"os/exec"
 	"strconv"
@@ -112,12 +113,8 @@ func RunTests(t *testing.T, cmdName string, extraTests map[string]TestCase) {
 	}
 
 	allTests := make(map[string]TestCase)
-	for name, test := range commonTests {
-		allTests[name] = test
-	}
-	for name, test := range extraTests {
-		allTests[name] = test
-	}
+	maps.Copy(allTests, commonTests)
+	maps.Copy(allTests, extraTests)
 
 	for name, tc := range allTests {
 		t.Run(name, func(t *testing.T) {