refactor: update to Python skill standards and fix CI

- Switch type checker from mypy to ty
- Expand ruff rules: add D, ANN, PT, RET, ARG, FA, N, RUF rule sets
- Add from __future__ import annotations to all modules
- Add Google-style pydocstyle convention
- Fix all ruff violations (docstrings, assertions, type alias syntax)
- Update requires-python from >=3.10 to >=3.12
- Configure ty to check api_client (HA modules need homeassistant stubs)

CI fixes:
- Update actions/checkout v4 -> v6 (Node.js 24)
- Update astral-sh/setup-uv v6 -> v7
- Update amannn/action-semantic-pull-request v5 -> v6
- Update DavidAnson/markdownlint-cli2-action v20 -> v23
- Fix lint job: mypy -> ty check
- Fix coverage path: --cov=src -> --cov=custom_components

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: mikejhill

.github/workflows/ci.yml

@@ -23,21 +23,21 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 5
     steps:
-      - uses: amannn/action-semantic-pull-request@v5
+      - uses: amannn/action-semantic-pull-request@v6
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
   lint:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@v4
-      - uses: astral-sh/setup-uv@v6
+      - uses: actions/checkout@v6
+      - uses: astral-sh/setup-uv@v7
       - run: uv sync --group dev
       - run: uv run ruff check .
       - run: uv run ruff format --check .
-      - name: Type check (core library only)
-        run: uv run mypy src --ignore-missing-imports
+      - name: Type check
+        run: uv run ty check
 
   test:
     runs-on: ${{ matrix.os }}
@@ -53,15 +53,15 @@ jobs:
             coverage: true
     name: "Test (${{ matrix.os }}, Python ${{ matrix.python-version }})"
     steps:
-      - uses: actions/checkout@v4
-      - uses: astral-sh/setup-uv@v6
+      - uses: actions/checkout@v6
+      - uses: astral-sh/setup-uv@v7
       - run: uv python install ${{ matrix.python-version }}
       - run: uv sync --group dev --python ${{ matrix.python-version }}
 
       - name: Run tests
         run: >-
           uv run pytest --junit-xml=test-results.xml
-          ${{ matrix.coverage && '--cov=src --cov-report=xml --cov-fail-under=80' || '' }}
+          ${{ matrix.coverage && '--cov=custom_components --cov-report=xml --cov-fail-under=80' || '' }}
 
       - name: Publish test report
         if: always()
@@ -81,8 +81,8 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@v4
-      - uses: astral-sh/setup-uv@v6
+      - uses: actions/checkout@v6
+      - uses: astral-sh/setup-uv@v7
       - run: uv build
       - uses: actions/upload-artifact@v4
         with:
@@ -94,8 +94,8 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 5
     steps:
-      - uses: actions/checkout@v4
-      - uses: DavidAnson/markdownlint-cli2-action@v20
+      - uses: actions/checkout@v6
+      - uses: DavidAnson/markdownlint-cli2-action@v23
 
   ci-pass:
     if: always()

.github/workflows/release.yml

@@ -21,7 +21,7 @@ jobs:
     timeout-minutes: 30
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           fetch-depth: 0
 
@@ -41,11 +41,11 @@ jobs:
           exit 1
 
       # ── Validation ──────────────────────────────────────────
-      - uses: astral-sh/setup-uv@v6
+      - uses: astral-sh/setup-uv@v7
       - run: uv sync --group dev
       - run: uv run ruff check .
       - run: uv run ruff format --check .
-      - run: uv run mypy src --ignore-missing-imports
+      - run: uv run ty check
       - run: uv run pytest
 
       # ── CHANGELOG ───────────────────────────────────────────

custom_components/rouvy/__init__.py

@@ -38,9 +38,7 @@ async def async_setup_entry(
     )
 
     await coordinator.async_config_entry_first_refresh()
-    await hass.config_entries.async_forward_entry_setups(
-        entry, [Platform.SENSOR]
-    )
+    await hass.config_entries.async_forward_entry_setups(entry, [Platform.SENSOR])
 
     _register_services(hass)
 
@@ -54,9 +52,7 @@ async def async_unload_entry(
     """Unload a Rouvy config entry."""
     from homeassistant.const import Platform
 
-    result: bool = await hass.config_entries.async_unload_platforms(
-        entry, [Platform.SENSOR]
-    )
+    result: bool = await hass.config_entries.async_unload_platforms(entry, [Platform.SENSOR])
     return result
 
 

custom_components/rouvy/api_client/__main__.py

@@ -1,6 +1,5 @@
 #!/usr/bin/env python3
-"""
-Rouvy API client - Command-line interface for making API calls.
+"""Rouvy API client - Command-line interface for making API calls.
 
 Supports both subcommands (profile, zones, apps, activities, set, raw)
 and legacy flags (--endpoint, --set, --raw) for backward compatibility.
@@ -528,6 +527,7 @@ def _legacy_main(client: RouvyClient, args: argparse.Namespace) -> None:
 
 
 def main() -> None:
+    """Parse arguments, configure logging, and dispatch the CLI command."""
     args = _parse_args()
     log_level = "DEBUG" if args.debug else args.log_level
     _configure_logging(log_level)

custom_components/rouvy/api_client/models.py

@@ -1,5 +1,4 @@
-"""
-Typed data models for Rouvy API responses.
+"""Typed data models for Rouvy API responses.
 
 These frozen dataclasses represent the structured data returned by various
 Rouvy API endpoints. They are HTTP-library-agnostic and can be used by

custom_components/rouvy/api_client/parser.py

@@ -1,5 +1,4 @@
-"""
-Parser for Rouvy API responses using turbo-stream format.
+"""Parser for Rouvy API responses using turbo-stream format.
 
 Rouvy uses the turbo-stream format from Remix (https://github.com/jacob-ebey/turbo-stream),
 which is a streaming data format that supports more types than JSON and uses indexed
@@ -40,8 +39,7 @@ def __init__(self) -> None:
         self.promise_values: dict[int, Any] = {}
 
     def decode(self, response_text: str) -> dict[str, Any] | list[Any] | Any:
-        """
-        Decode a turbo-stream formatted response.
+        """Decode a turbo-stream formatted response.
 
         Args:
             response_text: Raw response text (may be multi-line)
@@ -89,8 +87,7 @@ def _parse_promise_line(self, line: str) -> None:
             LOGGER.warning(f"Error parsing promise line '{line}': {e}")
 
     def _decode_value(self, value: Any, resolve_int_as_index: bool = False) -> Any:
-        """
-        Recursively decode a value, resolving references and special types.
+        """Recursively decode a value, resolving references and special types.
 
         Args:
             value: The value to decode
@@ -100,10 +97,10 @@ def _decode_value(self, value: Any, resolve_int_as_index: bool = False) -> Any:
         if isinstance(value, int):
             if value == -5:
                 return UNDEFINED
-            elif value == -7:
+            if value == -7:
                 return NULL
             # Only resolve as index if explicitly requested (for indexed object values)
-            elif (
+            if (
                 resolve_int_as_index
                 and value in self.index_map
                 and value not in getattr(self, "_resolving", set())
@@ -136,9 +133,8 @@ def _decode_value(self, value: Any, resolve_int_as_index: bool = False) -> Any:
                         return self._decode_value(
                             self.promise_values[promise_id], resolve_int_as_index=False
                         )
-                    else:
-                        # Promise not yet resolved
-                        return f"<Promise:{promise_id}>"
+                    # Promise not yet resolved
+                    return f"<Promise:{promise_id}>"
 
             # Regular array - decode each element (don't resolve ints as indices)
             return [self._decode_value(item, resolve_int_as_index=False) for item in value]
@@ -183,8 +179,7 @@ def _decode_value(self, value: Any, resolve_int_as_index: bool = False) -> Any:
         return value
 
     def extract_data_section(self, decoded: Any, path: str = "root.data") -> dict[str, Any]:
-        """
-        Extract a specific data section from the decoded structure.
+        """Extract a specific data section from the decoded structure.
 
         Args:
             decoded: Decoded turbo-stream data
@@ -210,8 +205,7 @@ def extract_data_section(self, decoded: Any, path: str = "root.data") -> dict[st
 
 
 def parse_response(response_text: str) -> dict[str, Any] | list[Any] | Any:
-    """
-    Parse a Rouvy API response in turbo-stream format.
+    """Parse a Rouvy API response in turbo-stream format.
 
     Args:
         response_text: Raw response text
@@ -224,8 +218,7 @@ def parse_response(response_text: str) -> dict[str, Any] | list[Any] | Any:
 
 
 def extract_user_profile(response_text: str) -> dict[str, Any]:
-    """
-    Extract user profile fields from user-settings response.
+    """Extract user profile fields from user-settings response.
 
     Args:
         response_text: Raw user-settings.data response

custom_components/rouvy/const.py

@@ -1,5 +1,7 @@
 """Constants for the Rouvy integration."""
 
+from __future__ import annotations
+
 import logging
 
 DOMAIN = "rouvy"

custom_components/rouvy/data.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 from dataclasses import dataclass
-from typing import TYPE_CHECKING, TypeAlias
+from typing import TYPE_CHECKING
 
 from homeassistant.config_entries import ConfigEntry
 from homeassistant.loader import Integration
@@ -22,4 +22,4 @@ class RouvyData:
     integration: Integration
 
 
-RouvyConfigEntry: TypeAlias = ConfigEntry[RouvyData]
+type RouvyConfigEntry = ConfigEntry[RouvyData]

pyproject.toml

@@ -7,7 +7,7 @@ name = "rouvy-api"
 version = "0.1.0"
 description = "A Home Assistant integration and CLI for the Rouvy indoor cycling platform with turbo-stream API support"
 readme = "README.md"
-requires-python = ">=3.10"
+requires-python = ">=3.12"
 authors = [{ name = "Mike Hill" }]
 dependencies = ["requests>=2.31.0", "python-dotenv>=1.0.0"]
 
@@ -16,13 +16,13 @@ rouvy-api = "custom_components.rouvy.api_client.__main__:main"
 
 [dependency-groups]
 dev = [
-    "pytest>=8.0.0",
-    "pytest-cov>=6.0.0",
+    "pytest>=8.0",
+    "pytest-cov>=6.0",
     "pytest-asyncio>=0.24.0",
     "responses>=0.25.0",
     "aiohttp>=3.9.0",
-    "ruff>=0.9.0",
-    "mypy>=1.14.0",
+    "ruff>=0.7",
+    "ty>=0.0.1",
     "types-requests>=2.31.0",
 ]
 
@@ -31,22 +31,39 @@ packages = ["custom_components"]
 
 [tool.ruff]
 line-length = 100
-target-version = "py310"
+target-version = "py312"
+src = ["custom_components", "tests"]
 
 [tool.ruff.lint]
-select = ["E", "F", "I", "W", "UP", "B", "SIM"]
+select = ["E", "W", "F", "I", "N", "UP", "B", "SIM", "RUF", "D", "ANN", "PT", "RET", "ARG", "FA"]
+ignore = ["D100", "D104", "D107", "D203", "D213"]
+
+[tool.ruff.lint.pydocstyle]
+convention = "google"
+
+[tool.ruff.lint.isort]
+known-first-party = ["custom_components"]
 
 [tool.ruff.lint.per-file-ignores]
-"tests/test_cli.py" = ["E402"]
-"tests/test_ha_api.py" = ["E402"]
-"scripts/*" = ["E501"]
-
-[tool.mypy]
-python_version = "3.10"
-warn_return_any = true
-warn_unused_configs = true
-disallow_untyped_defs = true
-check_untyped_defs = true
+"tests/*" = ["D101", "D102", "D103", "ANN", "ARG", "E402", "PT017"]
+"scripts/*" = ["D102", "D103", "ANN", "E501"]
+"custom_components/rouvy/__init__.py" = ["ANN401"]
+"custom_components/rouvy/coordinator.py" = ["ANN401"]
+"custom_components/rouvy/sensor.py" = ["ANN401", "ARG001"]
+"custom_components/rouvy/config_flow.py" = ["ANN401"]
+"custom_components/rouvy/entity.py" = ["ANN401"]
+"custom_components/rouvy/api.py" = ["ANN401"]
+"custom_components/rouvy/api_client/client.py" = ["ANN401"]
+"custom_components/rouvy/api_client/errors.py" = ["ANN401"]
+"custom_components/rouvy/api_client/parser.py" = ["ANN401"]
+
+[tool.ty.environment]
+python-version = "3.12"
+
+[tool.ty.src]
+# Only type-check the standalone API client; HA integration modules and tests
+# require homeassistant stubs which are not available in the dev environment.
+include = ["custom_components/rouvy/api_client/"]
 
 [tool.pytest.ini_options]
 testpaths = ["tests"]

scripts/debug_parser.py

@@ -1,6 +1,8 @@
 #!/usr/bin/env python3
 """Debug script to understand turbo-stream structure."""
 
+from __future__ import annotations
+
 import json
 import os
 import sys
@@ -37,7 +39,7 @@
         end = min(len(raw_data), i + 10)
         for j in range(start, end):
             marker = " <-- HERE" if j == i else ""
-            print(f"  [{j}]: {repr(raw_data[j])}{marker}")
+            print(f"  [{j}]: {raw_data[j]!r}{marker}")
         break
 
 # Find userProfile section
@@ -48,7 +50,7 @@
         end = min(len(raw_data), i + 5)
         for j in range(start, end):
             marker = " <-- HERE" if j == i else ""
-            print(f"  [{j}]: {repr(raw_data[j])}{marker}")
+            print(f"  [{j}]: {raw_data[j]!r}{marker}")
 
         # The value should be an object
         if i + 1 < len(raw_data):
@@ -66,4 +68,4 @@
 # Show just the first 20 elements decoded
 if isinstance(decoded, list):
     for i in range(min(20, len(decoded))):
-        print(f"[{i}]: {repr(decoded[i])}")
+        print(f"[{i}]: {decoded[i]!r}")