Announce marker contents via aria.alert in goto-error peek widget#316835
Merged
Conversation
Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix multiple accessibility issues in error message
Announce marker contents via aria.alert in goto-error peek widget
May 17, 2026
Contributor
|
@copilot I think we don't like aria.alert, isn't that what's in the instructions? |
Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Contributor
Author
You're right — the accessibility skill says to prefer |
meganrogge
approved these changes
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Improves screen reader support for the goto-error peek widget by announcing the actual problem text when the widget opens or the marker changes.
Changes:
- Call
aria.status(...)inMessageWidget.update()to announce the marker's aria label. - Include
marker.messagein the aria label returned bygetAriaLabel.
Show a summary per file
| File | Description |
|---|---|
| src/vs/editor/contrib/gotoError/browser/gotoErrorWidget.ts | Import aria module, announce label on update, and include the marker message in the aria label string. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
meganrogge
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen readers (Narrator in particular) did not announce the problem text when the inline marker peek widget is opened with F8. The widget's
aria-liveregion was present but unreliable, and itsaria-labelomitted the actual message — only severity, position, and the underlying line content were exposed.Changes
gotoErrorWidget.ts–MessageWidget.update(): explicitly callaria.alert(...)whenever the widget is shown at a marker or the marker changes, forcing a Narrator announcement when the user invokes "view problem".MessageWidget.getAriaLabel: includemarker.messagein the label so the actual problem text is conveyed alongside severity and location.Scope note
The two other bullets in the original report (tab-order of next/previous problem buttons; control names not announced) were confirmed by the area owner as working-as-designed (arrow-key navigation; reproducible only with one screen reader), so they are not addressed here.