fix EDGE_GPG_KEY not found error#274
Conversation
Use MS_GPG_KEYRING in place of EDGE_GPG_KEY var.
theneiljohnson
left a comment
There was a problem hiding this comment.
Approved — thanks Jason, this fixes a real crash.
EDGE_GPG_KEY is never defined anywhere in the script, so the Edge repo line was emitting signed-by= (empty) and apt failed. MS_GPG_KEYRING is correctly set at lines 248/253 and already used for the main PMC repo at line 269, so switching the Edge line to it is the right call and resolves the error for every current Ubuntu release.
One non-blocking nuance for a possible follow-up (no need to hold this PR): the comment at line ~241 notes the Edge repo uses the older microsoft.asc key on all versions. On Ubuntu 26.04+, MS_GPG_KEYRING resolves to microsoft-2025.gpg, so on those releases this line would point Edge at the 2025 key. If the Edge repo is still signed with the older key there, it'd be safer to hardcode the Edge line to the always-installed /usr/share/keyrings/microsoft.gpg. Not a blocker — your fix is strictly better than the broken state and correct for everything pre-26.04.
Use MS_GPG_KEYRING in place of EDGE_GPG_KEY var.