Skip to content

fix EDGE_GPG_KEY not found error#274

Open
Jason-Hendry wants to merge 1 commit into
microsoft:masterfrom
Jason-Hendry:patch-1
Open

fix EDGE_GPG_KEY not found error#274
Jason-Hendry wants to merge 1 commit into
microsoft:masterfrom
Jason-Hendry:patch-1

Conversation

@Jason-Hendry
Copy link
Copy Markdown

Use MS_GPG_KEYRING in place of EDGE_GPG_KEY var.

Use MS_GPG_KEYRING in place of EDGE_GPG_KEY var.
Copy link
Copy Markdown
Collaborator

@theneiljohnson theneiljohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — thanks Jason, this fixes a real crash.

EDGE_GPG_KEY is never defined anywhere in the script, so the Edge repo line was emitting signed-by= (empty) and apt failed. MS_GPG_KEYRING is correctly set at lines 248/253 and already used for the main PMC repo at line 269, so switching the Edge line to it is the right call and resolves the error for every current Ubuntu release.

One non-blocking nuance for a possible follow-up (no need to hold this PR): the comment at line ~241 notes the Edge repo uses the older microsoft.asc key on all versions. On Ubuntu 26.04+, MS_GPG_KEYRING resolves to microsoft-2025.gpg, so on those releases this line would point Edge at the 2025 key. If the Edge repo is still signed with the older key there, it'd be safer to hardcode the Edge line to the always-installed /usr/share/keyrings/microsoft.gpg. Not a blocker — your fix is strictly better than the broken state and correct for everything pre-26.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants