Skip to content

Commit a361cb6

Browse files
committed
refactor(devcontainer): remove custom CA workarounds per PR feedback
1 parent 0bd6e6c commit a361cb6

4 files changed

Lines changed: 4 additions & 19 deletions

File tree

.devcontainer/README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,10 @@ gitleaks detect --source . --verbose
100100

101101
Container won't build: Ensure Docker Desktop is running and you have sufficient disk space (5GB+).
102102

103-
Extensions not loading: Reload the window (`F1`**Developer: Reload Window**).
103+
1. **Extensions not loading**: Reload the window (`F1`**Developer: Reload Window**).
104+
105+
2. **HTTP/TLS errors during build**: Machines with corporate firewalls performing TLS inspection should ensure they are using the default `desktop-linux` builder, which honors OS root certificate trust stores.
106+
You can change the active builder back to `desktop-linux` by running `docker buildx use desktop-linux`.
104107

105108
For more help, see [SUPPORT.md](../SUPPORT.md).
106109

.devcontainer/devcontainer.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919
"target": "/workspace/node_modules"
2020
}
2121
],
22-
"containerEnv": {
23-
"REQUESTS_CA_BUNDLE": "/etc/ssl/certs/ca-certificates.crt", // for pip
24-
"NODE_EXTRA_CA_CERTS": "/etc/ssl/certs/ca-certificates.crt", // for nodejs
25-
"SSL_CERT_FILE": "/etc/ssl/certs/ca-certificates.crt" // for uv (else use --native-tls flag)
26-
},
2722
"features": {
2823
"ghcr.io/devcontainers/features/node:1": {
2924
"version": "20"

.devcontainer/scripts/post-create.sh

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ main() {
1313

1414
fix_volume_ownerships
1515
npm_install
16-
update_ca_certs
1716
}
1817

1918
# Volume ownership is not set automatically due to a bug:
@@ -44,15 +43,4 @@ npm_install() {
4443
echo "NPM dependencies installed successfully"
4544
}
4645

47-
update_ca_certs() {
48-
# Adds a root CA to the system certificate store. Useful if developer machines
49-
# have MITM TLS inspection happening, e.g. with ZScaler.
50-
echo "Updating container system CA certificates..."
51-
if compgen -G ".devcontainer/*.crt" > /dev/null; then
52-
sudo cp .devcontainer/*.crt /usr/local/share/ca-certificates/
53-
sudo update-ca-certificates
54-
fi
55-
echo "Container's system CA certificates updated successfully"
56-
}
57-
5846
main "$@"

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,4 +469,3 @@ docs/docusaurus/node_modules/
469469
# devcontainer
470470
/.gitconfig.global
471471
/.gitconfig.local
472-
/.devcontainer/*.crt

0 commit comments

Comments
 (0)