Removed intermediate list when processing offsets in cddb_query_string

phw · phw · commit e9c98d09b2a3 · 2026-08-07T14:24:29.000+02:00
diff --git a/discid/disc.py b/discid/disc.py
@@ -413,7 +413,7 @@ def cddb_query_string(self) -> str:
 
         .. seealso:: `CDDB Server Protocol <https://gnudb.org/howtognudb.php>`_
         """
-        offset_str = " ".join([str(track.offset) for track in self.tracks])
+        offset_str = " ".join(str(track.offset) for track in self.tracks)
         cddb_query_string = (
             f"{self.freedb_id} {self.last_track_num} {offset_str} {self.seconds}"
         )

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ def cddb_query_string(self) -> str:`
`413`	`413`
`414`	`414`	.. seealso:: `CDDB Server Protocol <https://gnudb.org/howtognudb.php>`_
`415`	`415`	`"""`
`416`		`- offset_str = " ".join([str(track.offset) for track in self.tracks])`
	`416`	`+ offset_str = " ".join(str(track.offset) for track in self.tracks)`
`417`	`417`	`cddb_query_string = (`
`418`	`418`	`f"{self.freedb_id} {self.last_track_num} {offset_str} {self.seconds}"`
`419`	`419`	`)`