Prefer list comprehension / list.extend over filling lists in loops

Author: phw

discid/disc.py

@@ -398,11 +398,11 @@ def mcn(self) -> str | None:
     @property
     def tracks(self) -> list[Track]:
         """A list of :class:`Track` objects for this Disc."""
-        tracks: list[Track] = []
         assert self._success
-        for number in range(self.first_track_num, self.last_track_num + 1):
-            tracks.append(Track(self, number))
-        return tracks
+        return [
+            Track(self, number)
+            for number in range(self.first_track_num, self.last_track_num + 1)
+        ]
 
     @property
     def cddb_query_string(self) -> str:

discid/libdiscid.py

@@ -156,9 +156,7 @@ def _get_features():
     if _features_available:
         c_features = (c_char_p * 32)()
         _LIB.discid_get_feature_list(c_features)
-        for feature in c_features:
-            if feature:
-                features.append(_decode(feature))
+        features.extend(_decode(feature) for feature in c_features if feature)
     else:
         # libdiscid <= 0.4.0
         features = ["read"]  # no generic platform yet

pyproject.toml

@@ -51,4 +51,4 @@ discid = ["py.typed"]
 src=["discid"]
 
 [tool.ruff.lint]
-select = ["E", "F", "B", "I", "UP", "RUF", "PYI"]
+select = ["E", "F", "B", "I", "UP", "RUF", "PYI", "PERF"]