Skip to content

Commit 5cc36c5

Browse files
FindHaometa-codesync[bot]
authored andcommitted
Add website build CI test and update dependencies (#224)
Summary: This PR adds a CI workflow to test website builds on pull requests and updates all website dependencies to their latest versions. ## Changes - Add `website-build.yml` workflow that tests website builds on PRs to main - Remove conflicting `yarn.lock` file (standardize on npm) - Add website-related Makefile targets for local development - Update all website dependencies to latest versions: - React 19.2.0 → 19.2.3 - Vite 7.2.4 → 7.3.0 - TypeScript-ESLint 8.47.0 → 8.50.1 - react-resizable-panels 3.0.6 → 4.0.15 - And other minor updates - Fix react-resizable-panels v4 API compatibility: - `PanelGroup` → `Group` - `PanelResizeHandle` → `Separator` Pull Request resolved: #224 Test Plan: - CI will automatically verify the website builds successfully when this PR is created - Local build tested: `npm run build` completes successfully Reviewed By: karthik-man Differential Revision: D89700500 Pulled By: FindHao fbshipit-source-id: 3cf42d1a476e7216bcb6841175bbaad00c2a6b31
1 parent a205e50 commit 5cc36c5

6 files changed

Lines changed: 434 additions & 2708 deletions

File tree

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
name: Website Build Test
2+
3+
on:
4+
push:
5+
branches: [main]
6+
paths:
7+
- "website/**"
8+
- ".github/workflows/website-build.yml"
9+
pull_request:
10+
branches: [main]
11+
paths:
12+
- "website/**"
13+
- ".github/workflows/website-build.yml"
14+
workflow_dispatch:
15+
16+
jobs:
17+
build-test:
18+
runs-on: ubuntu-slim
19+
timeout-minutes: 10
20+
21+
steps:
22+
- name: Checkout repository
23+
uses: actions/checkout@v4
24+
25+
- name: Setup Node.js
26+
uses: actions/setup-node@v4
27+
with:
28+
node-version: "24"
29+
cache: "npm"
30+
cache-dependency-path: "website/package-lock.json"
31+
32+
- name: Install dependencies
33+
working-directory: ./website
34+
run: npm ci
35+
36+
- name: Build website
37+
working-directory: ./website
38+
run: npm run build
39+
40+
- name: Build standalone website
41+
working-directory: ./website
42+
run: npm run build:single
43+
44+
- name: Verify build output
45+
run: |
46+
if [ ! -d "website/dist" ]; then
47+
echo "❌ Build failed: dist directory not found"
48+
exit 1
49+
fi
50+
if [ ! -f "website/dist/index.html" ]; then
51+
echo "❌ Build failed: index.html not found"
52+
exit 1
53+
fi
54+
if [ ! -f "website/dist/standalone.html" ]; then
55+
echo "❌ Build failed: standalone.html not found"
56+
exit 1
57+
fi
58+
echo "✅ Build successful: all expected files present"
59+
ls -la website/dist/

Makefile

Lines changed: 37 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,25 @@
11
# Makefile for tritonparse project
22

3-
.PHONY: help format format-check lint lint-check test test-cuda clean install-dev
3+
.PHONY: help format format-check lint lint-check test test-cuda clean install-dev website-install website-lint website-build website-build-single website-dev
44

55
# Default target
66
help:
77
@echo "Available targets:"
8-
@echo " format - Format all Python files"
9-
@echo " format-check - Check formatting without making changes"
10-
@echo " lint - Run all linters"
11-
@echo " lint-check - Check linting without making changes"
12-
@echo " test - Run tests (CPU only)"
13-
@echo " test-cuda - Run tests (including CUDA tests)"
14-
@echo " clean - Clean up cache files"
15-
@echo " install-dev - Install development dependencies"
8+
@echo " format - Format all Python files"
9+
@echo " format-check - Check formatting without making changes"
10+
@echo " lint - Run all linters"
11+
@echo " lint-check - Check linting without making changes"
12+
@echo " test - Run tests (CPU only)"
13+
@echo " test-cuda - Run tests (including CUDA tests)"
14+
@echo " clean - Clean up cache files"
15+
@echo " install-dev - Install development dependencies"
16+
@echo ""
17+
@echo "Website targets:"
18+
@echo " website-install - Install website dependencies"
19+
@echo " website-lint - Run ESLint on website"
20+
@echo " website-build - Build website"
21+
@echo " website-build-single - Build standalone website"
22+
@echo " website-dev - Run website dev server"
1623

1724
# Formatting targets
1825
format:
@@ -56,3 +63,24 @@ clean:
5663
install-dev:
5764
@echo "Installing development dependencies..."
5865
pip install -U black usort ruff coverage
66+
67+
# Website targets
68+
website-install:
69+
@echo "Installing website dependencies..."
70+
cd website && npm ci
71+
72+
website-lint:
73+
@echo "Running ESLint on website..."
74+
cd website && npm run lint
75+
76+
website-build:
77+
@echo "Building website..."
78+
cd website && npm run build
79+
80+
website-build-single:
81+
@echo "Building standalone website..."
82+
cd website && npm run build:single
83+
84+
website-dev:
85+
@echo "Starting website dev server..."
86+
cd website && npm run dev

0 commit comments

Comments
 (0)