Cleaning up uses of std::string vs std::string_view #1256

We've been using both inconsistently. We should have a principled reason to use one vs the other. Note that we migrated a bunch of previous uses of std::string_view to std::string since the torch stable ABI requires it.