Open
Conversation
github-actions
bot
added
data:api
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
requested changes
Mar 27, 2026
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
LGTM overall, except:
- One feature was added in 26, not 26.2.
- All Safari iOS support statements should be changed to
"mirror", cf. failing lint.
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| "version_added": "26.2" |
Contributor
There was a problem hiding this comment.
WebKit/WebKit@19d4721 in WK 622.1.7 before Safari 26 (WK 622.1.22).
Suggested change
| "version_added": "26.2" | |
| "version_added": "26" |
Comment on lines
+273
to
+274
| "safari_ios": { | ||
| "version_added": "26.2" |
Contributor
There was a problem hiding this comment.
Same:
Suggested change
| "safari_ios": { | |
| "version_added": "26.2" | |
| "safari_ios": { | |
| "version_added": "26" |
npm run lint:fix will replace the object with "mirror".
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| "version_added": "26.2" |
Contributor
There was a problem hiding this comment.
Confirmed via WebKit/WebKit@316fd53 in WK 623.1.5 after Safari 26.1 (622.2.11) before Safari 26.2 (623.1.14)
Contributor
|
@ferminLR Have you had a chance to look at my review comments? 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With WebGPU support enabled by default in Safari 26 (shipped with macOS 26 Tahoe and iOS 26) a bunch of WebGPU features were enabled. All the features marked in this PR with
"version_added" : "26"were already available in previous Safari versions with the WebGPU flag enabled, and are now enabled by default.Both
core-features-and-limitsandtexture-formats-tier1are enabled at least in Safari 26.2. I don't have access to a machine with 26.1 or 26.0 and I haven't found when they were added.Test results and supporting details
Related issues