DIAG v10: fix SNDR resolution (typed BSISoundDescriptor cast, not void*)

The CommonLib header settled it: BGSSoundDescriptorForm multiply-inherits
BSISoundDescriptor at +0x28 (TESForm is the offset-0 base), and the inner
BGSSoundDescriptor is-a BSISoundDescriptor at offset 0. So the descriptor the
game passes is either form+0x28 or the inner descriptor. v8/v9 compared void*
of the form base (offset 0), which never matches form+0x28 -> SNDR 00000000.

v10 compares static_cast<BSISoundDescriptor*>(snd) and
static_cast<BSISoundDescriptor*>(snd->soundDescriptor) against a_desc, letting
the compiler apply the base adjustment. Now the enchant SFX resolves to its real
FormID + editorID -> the target for the static dummy-replace. vtbl dump retained
as backup. Still pure log-only.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: marthofdoom

native/plugin.cpp

@@ -5770,13 +5770,21 @@ namespace sndhook {
                 // at most 12 times total, never at shutdown since it's in-window only).
                 // Match either the form pointer itself OR its inner soundDescriptor —
                 // PlaySound may hand us either.
+                // BGSSoundDescriptorForm multiply-inherits BSISoundDescriptor at +0x28, and
+                // its inner BGSSoundDescriptor also IS-A BSISoundDescriptor (at offset 0). The
+                // game may hand BuildSound EITHER subobject, so compare with proper typed casts
+                // (the compiler applies the base-offset adjustment) — a void* compare misses the
+                // form-subobject case, which is what left v8/v9 at SNDR 00000000.
                 std::uint32_t fid  = 0;
                 const char*   edid = "";
                 void*         dp   = static_cast<void*>(a_desc);
                 if (auto* dh = RE::TESDataHandler::GetSingleton()) {
                     for (auto* snd : dh->GetFormArray<RE::BGSSoundDescriptorForm>()) {
-                        if (snd && (static_cast<void*>(snd) == dp ||
-                                    static_cast<void*>(snd->soundDescriptor) == dp)) {
+                        if (!snd) continue;
+                        const bool hitForm  = static_cast<RE::BSISoundDescriptor*>(snd) == a_desc;
+                        const bool hitInner = snd->soundDescriptor &&
+                                              static_cast<RE::BSISoundDescriptor*>(snd->soundDescriptor) == a_desc;
+                        if (hitForm || hitInner) {
                             fid  = snd->GetFormID();
                             edid = snd->GetFormEditorID();
                             break;