Documentation is
Explain in Detail
The documentation for marimo run says that "the python code is hidden and uneditable" by default, but that does not imply that the code is never sent to the client.
Hypothetically what the sentence could mean is that the code is hidden by default and that the user can click a button to show it, or that the code is never shown but still sent and can be accessed through the dev tools.
The code truly never being sent is important for scenarios where the source code of the notebook is confidential information that shouldn't be leaked.
Relevant unit test:
|
async def test_kernel_ready_sends_names_but_not_code_when_include_code_false( |
Your Suggestion for Changes
Add "and never sent to the client" in relevant places. At minimum it should be added to the description of the --include-code flag (https://docs.marimo.io/cli/#marimo-run) but ideally it will also be added to other relevant places (https://docs.marimo.io/guides/deploying/)
Will you submit a PR?
Documentation is
Explain in Detail
The documentation for
marimo runsays that "the python code is hidden and uneditable" by default, but that does not imply that the code is never sent to the client.Hypothetically what the sentence could mean is that the code is hidden by default and that the user can click a button to show it, or that the code is never shown but still sent and can be accessed through the dev tools.
The code truly never being sent is important for scenarios where the source code of the notebook is confidential information that shouldn't be leaked.
Relevant unit test:
marimo/tests/_server/api/endpoints/test_ws.py
Line 252 in d559ab7
Your Suggestion for Changes
Add "and never sent to the client" in relevant places. At minimum it should be added to the description of the
--include-codeflag (https://docs.marimo.io/cli/#marimo-run) but ideally it will also be added to other relevant places (https://docs.marimo.io/guides/deploying/)Will you submit a PR?