Skip to content

ui: Adopted deemphasize flag in Sliders and Configuration menus #15283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuavas merged 2 commits into from
May 3, 2026
+12 −7
Merged

ui: Adopted deemphasize flag in Sliders and Configuration menus #15283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
277333a
ui: Adopted deemphasize flag in Sliders and Configuration menus
holub Apr 29, 2026
eb722f0
ui/menu.cpp: Backed out change to de-emphasised item colour.
cuavas May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/frontend/mame/ui/confswitch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ void menu_confswitch::populate()
if (field.has_next_setting())
flags |= FLAG_RIGHT_ARROW;

if (field.live().value == field.defvalue())
flags |= FLAG_DEEMPHASIZE;

// add the menu item
item_append(field.name(), field.setting_name(), flags, &field);
}
Expand Down
12 changes: 5 additions & 7 deletions src/frontend/mame/ui/menu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,13 +883,11 @@ void menu::draw(uint32_t flags)

// customize subitem text color
if (!core_stricmp(pitem.subtext(), _("On")))
fgcolor2 = rgb_t(0x00,0xff,0x00);

if (!core_stricmp(pitem.subtext(), _("Off")))
fgcolor2 = rgb_t(0xff,0x00,0x00);

if (!core_stricmp(pitem.subtext(), _("Auto")))
fgcolor2 = rgb_t(0xff,0xff,0x00);
fgcolor2 = rgb_t(0x00, 0xff, 0x00);
else if (!core_stricmp(pitem.subtext(), _("Off")))
fgcolor2 = rgb_t(0xff, 0x00, 0x00);
else if (!core_stricmp(pitem.subtext(), _("Auto")))
fgcolor2 = rgb_t(0xff, 0xff, 0x00);

// draw the subitem right-justified
ui().draw_text_full(
Expand Down
4 changes: 4 additions & 0 deletions src/frontend/mame/ui/sliders.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ void menu_sliders::populate()
flags |= FLAG_LEFT_ARROW;
if (curval < slider->maxval)
flags |= FLAG_RIGHT_ARROW;
if (curval == slider->defval)
flags |= FLAG_DEEMPHASIZE;
item_append(slider->description, tempstring, flags, (void *)slider, menu_item_type::SLIDER);
}
}
Expand All @@ -225,6 +227,8 @@ void menu_sliders::populate()
flags |= FLAG_LEFT_ARROW;
if (curval < slider->maxval)
flags |= FLAG_RIGHT_ARROW;
if (curval == slider->defval)
flags |= FLAG_DEEMPHASIZE;
item_append(slider->description, tempstring, flags, (void *)slider, menu_item_type::SLIDER);
}
else
Expand Down
Loading