Skip to content

Commit e9d5b8d

Browse files
Copilotluisgizirian
andcommitted
Fix pattern consistency and comment accuracy based on code review
Co-authored-by: luisgizirian <598685+luisgizirian@users.noreply.github.com>
1 parent 158801d commit e9d5b8d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

internal/defender/defender.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ func NewDefender(opts DefenderOptions) *Defender {
157157
`[?&](redirect|return|url|next|dest|destination|continue|view|target|redir|r|u)=https?://`, // Open redirect
158158
`[?&](redirect|return|url|next|dest|destination|continue|view|target|redir|r|u)=//`, // Protocol-relative redirect
159159
`[?&](redirect|return|url|next|dest|destination|continue|view|target|redir|r|u)=.*%2f%2f`, // Encoded // in redirect
160-
`(returnUrl|redirect|return|url|next|dest|destination|continue|view|target|redir).*%25[23]`, // Excessive URL-encoded nesting (4+ levels)
160+
`[?&](returnUrl|redirect|return|url|next|dest|destination|continue|view|target|redir).*%25[23]`, // Excessive URL-encoded nesting (4+ levels)
161161
}
162162

163163
for _, pattern := range patterns {

internal/defender/defender_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1042,7 +1042,7 @@ func TestDefender_ExcessiveURLEncodedNesting(t *testing.T) {
10421042
name: "Excessive nesting with redirect param",
10431043
uri: "/auth?redirect=/page1?redirect%3D/page2?redirect%253D/page3",
10441044
suspicious: true,
1045-
reason: "3+ levels of URL encoding detected",
1045+
reason: "4+ levels of URL encoding detected",
10461046
},
10471047
{
10481048
name: "Simple redirect - no nesting",

0 commit comments

Comments
 (0)