Commit f35bebc
committed
fix(settings): dupe all strings on first-run to prevent Bus error in deinit
When settings.json does not exist (first run), the FileNotFound branch
returned a Settings struct with comptime string constants from default
(e.g. preferred_mirror = "", proxy = ""). Since deinit() unconditionally
calls allocator.free() on these fields, the GPA attempted to write
@Memset on read-only memory, causing a Bus error at exit.
Dupe all string fields via allocator in the FileNotFound branch so
every string is heap-allocated and safe to free in deinit.
Also show active Zig version after successful upgrade.1 parent c6b47c6 commit f35bebc
2 files changed
Lines changed: 35 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
61 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
62 | 72 | | |
63 | 73 | | |
64 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
317 | 317 | | |
318 | 318 | | |
319 | 319 | | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
320 | 342 | | |
321 | 343 | | |
322 | 344 | | |
0 commit comments