Skip to content

Commit 75233d9

Browse files
committed
fixup! fixup! fixup! TF-4400 Add collapseThreads for load more & refresh change when force email query = true
1 parent 4d6641c commit 75233d9

3 files changed

Lines changed: 13 additions & 11 deletions

File tree

model/lib/email/presentation_email.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ class PresentationEmail with EquatableMixin, SearchSnippetMixin, ThreadMixin {
261261
MessageIdsHeaderValue? messageId,
262262
MessageIdsHeaderValue? references,
263263
List<EmailId>? emailIdsInThread,
264+
bool clearEmailIdsInThread = false,
264265
}) {
265266
return PresentationEmail(
266267
id: id ?? this.id,
@@ -294,6 +295,7 @@ class PresentationEmail with EquatableMixin, SearchSnippetMixin, ThreadMixin {
294295
emailInThreadStatus: emailInThreadStatus ?? this.emailInThreadStatus,
295296
messageId: messageId ?? this.messageId,
296297
references: references ?? this.references,
297-
)..emailIdsInThread = emailIdsInThread ?? this.emailIdsInThread;
298+
)..emailIdsInThread =
299+
clearEmailIdsInThread ? null : (emailIdsInThread ?? this.emailIdsInThread);
298300
}
299301
}

test/features/mailbox_dashboard/presentation/controller/mailbox_dashboard_controller_test.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -495,9 +495,9 @@ void main() {
495495
getLatestChanges: false,
496496
propertiesCreated: ThreadConstants.propertiesDefault,
497497
propertiesUpdated: ThreadConstants.propertiesUpdatedDefault,
498-
useCache: anyNamed('useCache'),
499-
forceEmailQuery: anyNamed('forceEmailQuery'),
500-
collapseThreads: anyNamed('collapseThreads')));
498+
useCache: true,
499+
forceEmailQuery: false,
500+
collapseThreads: false));
501501
});
502502

503503
test('WHEN user use advanced search/sort/filter feature, '
@@ -555,13 +555,13 @@ void main() {
555555
testSession, testAccountId,
556556
limit: ThreadConstants.defaultLimit,
557557
sort: EmailSortOrderType.mostRecent.getSortOrder().toNullable(),
558-
emailFilter: anyNamed('emailFilter'),
558+
emailFilter: threadController.getEmailFilterForLoadMailbox(),
559559
getLatestChanges: false,
560560
propertiesCreated: ThreadConstants.propertiesDefault,
561561
propertiesUpdated: ThreadConstants.propertiesUpdatedDefault,
562-
useCache: anyNamed('useCache'),
563-
forceEmailQuery: anyNamed('forceEmailQuery'),
564-
collapseThreads: anyNamed('collapseThreads')
562+
useCache: true,
563+
forceEmailQuery: false,
564+
collapseThreads: false
565565
)).called(1);
566566
});
567567

test/features/search/verify_before_time_in_search_email_filter_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -863,7 +863,7 @@ void main() {
863863
),
864864
propertiesUpdated: ThreadConstants.propertiesUpdatedDefault,
865865
emailFilter: threadController.getEmailFilterForLoadMailbox(),
866-
collapseThreads: anyNamed('collapseThreads'),
866+
collapseThreads: mailboxDashboardController.collapseThreads,
867867
)).called(1);
868868

869869
verify(mockSearchEmailInteractor.execute(
@@ -1031,7 +1031,7 @@ void main() {
10311031
),
10321032
propertiesUpdated: ThreadConstants.propertiesUpdatedDefault,
10331033
emailFilter: threadController.getEmailFilterForLoadMailbox(),
1034-
collapseThreads: anyNamed('collapseThreads'),
1034+
collapseThreads: mailboxDashboardController.collapseThreads,
10351035
)).called(1);
10361036

10371037
verify(mockSearchEmailInteractor.execute(
@@ -1144,7 +1144,7 @@ void main() {
11441144
),
11451145
propertiesUpdated: ThreadConstants.propertiesUpdatedDefault,
11461146
emailFilter: threadController.getEmailFilterForLoadMailbox(),
1147-
collapseThreads: anyNamed('collapseThreads'),
1147+
collapseThreads: mailboxDashboardController.collapseThreads,
11481148
)).called(1);
11491149

11501150
verify(mockSearchEmailInteractor.execute(

0 commit comments

Comments
 (0)