feat: public imports for environment linters inside of lake lint in module system mode#13843
Merged
wkrozowski merged 2 commits intoMay 27, 2026
Merged
Conversation
…in module system mode
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 27, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
May 27, 2026
Kha
reviewed
May 27, 2026
| let modFile ← findOLean mod | ||
| let (modData, region) ← readModuleData modFile | ||
| let isModule ← getIsModule modData | ||
| let level := if isModule then OLeanLevel.exported else OLeanLevel.private |
Member
There was a problem hiding this comment.
level should be irrelevant for non-modules (they only have a single scope) so you should be able to just always pass exported
Contributor
Author
There was a problem hiding this comment.
Oh I see, that makes sense! Let me fix that.
Contributor
Author
There was a problem hiding this comment.
Hmm, so when I always pass .exported I get "error: cannot import non-module Main from module".
Contributor
Author
There was a problem hiding this comment.
For a non-module top-level file Main.lean
Member
There was a problem hiding this comment.
Oops, that probably makes sense. It really should only be this final check though, I wonder if we should create an opt-out to simplify tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
lake lint --builtin-lintimport module-system targets at the public (OLeanLevel.exported) level instead ofprivate. Environment linters now lint the public surface of such modules, matching how downstream consumers see them. Non-module targets retain their previous behaviour (privatelevel), and text-linter warnings recorded vialintLogExtare preserved across the level change because that extension stores uniform OLean entries.The top-level module's
.oleanis peeked viafindOLean+readModuleDatato decide whether to use.exportedor.private, mirroringprocessHeaderCore. A newtests/lake/tests/builtin-lint-module/test exercises the new code path with a dummy env linter and verifies that text-linter warnings on both public and private definitions survive the level switch.