Skip to content

feat: break MePo score ties by overlap#13834

Closed
raphael-solace wants to merge 1 commit into
leanprover:masterfrom
raphael-solace:rc/mepo-overlap-tiebreak
Closed

feat: break MePo score ties by overlap#13834
raphael-solace wants to merge 1 commit into
leanprover:masterfrom
raphael-solace:rc/mepo-overlap-tiebreak

Conversation

@raphael-solace
Copy link
Copy Markdown

@raphael-solace raphael-solace commented May 25, 2026

This PR makes MePo premise suggestions less likely to rank tiny generic theorems ahead of equally-scored domain-specific lemmas.

MePo now breaks score ties within a single iteration by preferring candidates that share more constants with the current relevant set. This does not change which candidates pass the threshold.

A regression check verifies that Int.add_comm ranks before generic Eq.symm for an integer commutativity goal.

Fixes #13749.

Tests: git diff --check locally. I did not run the Lean test suite locally because this workspace is a shallow sparse checkout without a local Lean toolchain.

@raphael-solace
Copy link
Copy Markdown
Author

I do not have permission to add labels on this repo. This should get \ (or another maintainer-preferred changelog label) to satisfy the PR body check.

@raphael-solace
Copy link
Copy Markdown
Author

Correction: the needed label is changelog-tactics (or another maintainer-preferred changelog label).

@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 25, 2026
@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-05-25 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-05-25 12:40:44)

@github-actions github-actions Bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label May 25, 2026
@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 25, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

@Kha
Copy link
Copy Markdown
Member

Kha commented May 26, 2026

Thank you for your contributions but if we want to fix these issues with AI, it will be easier to do it ourselves.

@Kha Kha closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mepo: score function over-rewards tiny generic theorems

3 participants