fix warnings

Author: lyang2821

crates/api/src/devbox.rs

@@ -793,7 +793,7 @@ impl DevboxSessionRpc for DevboxSessionRpcServer {
                 .ok_or_else(|| "Workload not found".to_string())?;
 
             let port_mappings: Vec<lapdev_devbox_rpc::PortMapping> =
-                serde_json::from_value(serde_json::Value::from(intercept.port_mappings.clone()))
+                serde_json::from_value(intercept.port_mappings.clone())
                     .map_err(|e| format!("Failed to parse port mappings: {}", e))?;
 
             result.push(lapdev_devbox_rpc::WorkloadInterceptInfo {

crates/api/src/devbox_tunnels.rs

@@ -155,7 +155,7 @@ pub(crate) fn split_axum_websocket(
     let (sink, stream) = socket.split();
 
     let sink = sink
-        .sink_map_err(|err| io::Error::other(err))
+        .sink_map_err(io::Error::other)
         .with(|message: TungMessage| future::ready(map_tungstenite_to_axum(message)));
 
     let stream = stream.filter_map(|msg| {

crates/api/src/kube_controller/deployment.rs

@@ -12,7 +12,6 @@ impl KubeController {
         workloads_with_resources: lapdev_kube_rpc::KubeWorkloadsWithResources,
         extra_labels: Option<HashMap<String, String>>,
     ) -> Result<(), ApiError> {
-        let workloads_with_resources = workloads_with_resources;
         let namespace = &environment.namespace;
         let environment_name = &environment.name;
 

crates/api/src/kube_controller/environment.rs

@@ -138,7 +138,7 @@ impl KubeController {
             )
             .collect();
 
-        let total_pages = (total_count + pagination.page_size - 1) / pagination.page_size;
+        let total_pages = total_count.div_ceil(pagination.page_size);
 
         Ok(PaginatedResult {
             data: kube_environments,
@@ -579,7 +579,7 @@ impl KubeController {
     pub async fn delete_kube_environment(
         &self,
         org_id: Uuid,
-        user_id: Uuid,
+        _user_id: Uuid,
         environment_id: Uuid,
     ) -> Result<(), ApiError> {
         // Authorize deletion (HRPC already enforced ownership/role, so we just ensure the environment exists and belongs to the org)
@@ -732,8 +732,8 @@ impl KubeController {
 
     pub async fn pause_kube_environment(
         &self,
-        org_id: Uuid,
-        user_id: Uuid,
+        _org_id: Uuid,
+        _user_id: Uuid,
         environment_id: Uuid,
     ) -> Result<(), ApiError> {
         let environment = self
@@ -2327,12 +2327,10 @@ impl KubeController {
         // Only insert/update workloads that were actually deployed
         for workload in workloads_to_deploy {
             let details = &workload.details;
-            let containers_json = serde_json::to_value(&details.containers)
-                .map(Json::from)
-                .unwrap_or_else(|_| Json::from(serde_json::json!([])));
-            let ports_json = serde_json::to_value(&details.ports)
-                .map(Json::from)
-                .unwrap_or_else(|_| Json::from(serde_json::json!([])));
+            let containers_json =
+                serde_json::to_value(&details.containers).unwrap_or_else(|_| serde_json::json!([]));
+            let ports_json =
+                serde_json::to_value(&details.ports).unwrap_or_else(|_| serde_json::json!([]));
             let workload_yaml = details.workload_yaml.clone();
 
             let existing_workload = lapdev_db_entities::kube_environment_workload::Entity::find()

crates/api/src/kube_controller/workload.rs

@@ -214,8 +214,8 @@ impl KubeController {
 
     pub async fn update_environment_workload(
         &self,
-        org_id: Uuid,
-        user_id: Uuid,
+        _org_id: Uuid,
+        _user_id: Uuid,
         workload_id: Uuid,
         containers: Vec<lapdev_common::kube::KubeContainerInfo>,
         environment: lapdev_db_entities::kube_environment::Model,

crates/conductor/src/scheduler.rs

@@ -299,7 +299,6 @@ mod tests {
     use std::collections::HashSet;
 
     use chrono::Utc;
-    use lapdev_common::{utils, PrebuildStatus, WorkspaceHostStatus, WorkspaceStatus};
     use lapdev_db::tests::prepare_db;
     use sea_orm::{ActiveModelTrait, ActiveValue, TransactionTrait};
     use uuid::Uuid;