feat(namespace): pluggable auth providers for REST Namespace with AWS SigV4#7099
Open
shiwk wants to merge 5 commits into
Open
feat(namespace): pluggable auth providers for REST Namespace with AWS SigV4#7099shiwk wants to merge 5 commits into
shiwk wants to merge 5 commits into
Conversation
2f11cea to
b0817e5
Compare
BREAKING CHANGE: RestNamespaceBuilder::build() now returns Result<RestNamespace>; direct Rust callers must add `?`. ConnectBuilder::connect() users are unaffected.
bcd4fdb to
d59a620
Compare
d59a620 to
b5f7f1f
Compare
Author
|
@jackye1995 Could you help review this when you have time? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements pluggable authentication for REST Namespace, with AWS SigV4 as the first provider. Closes #6583.
RestAuthProvidertrait with per-requestauthenticate()and connect-timeinitialize()for fail-fast credential validationSigV4AuthProviderusing theaws-sigv4crate, with credentials resolved via explicit properties or the standard AWS chain (env vars, profile, IMDS)rest.auth.sigv4.access-key-id,rest.auth.sigv4.secret-access-key, andrest.auth.sigv4.session-tokenproperties, taking precedence over the AWS default chainrest.auth.type=sigv4pass transparently to Rustx-amz-content-sha256header for S3-compatible service supportrest.auth.*andheader.Authorizationare mutually exclusive; misconfiguration is caught at build timeConfiguration
Test plan
--all-features