Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
members = [
"crates/lance-graph",
"crates/lance-graph-catalog",
"crates/lance-graph-python",
# lance-graph-python excluded: pyarrow `links = "python"` conflict with pyo3.
# Build separately with `maturin develop`.
]
Comment on lines 2 to 7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Exclude the Python crate when removing it from workspace members

Removing crates/lance-graph-python from workspace.members without adding it to workspace.exclude (or adding an empty [workspace] in that crate) makes Cargo reject the crate as an in-tree non-member: cargo check --manifest-path crates/lance-graph-python/Cargo.toml now fails with “current package believes it's in a workspace when it's not.” This is an immediate regression because .github/workflows/release.yml still runs that exact cargo check command for the Python crate.

Useful? React with 👍 / 👎.

resolver = "2"
6 changes: 3 additions & 3 deletions crates/lance-graph-catalog/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ keywords = ["lance", "graph", "catalog", "namespace"]
categories = ["database", "data-structures", "science"]

[dependencies]
arrow-schema = "56.2"
arrow-schema = "57"
async-trait = "0.1"
datafusion = { version = "50.3", default-features = false }
lance-namespace = "1.0.1"
datafusion = { version = "51", default-features = false }
lance-namespace = "2"
snafu = "0.8"

[dev-dependencies]
Expand Down
10 changes: 5 additions & 5 deletions crates/lance-graph-python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ name = "_internal"
crate-type = ["cdylib"]

[dependencies]
arrow = { version = "56.2", features = ["pyarrow"] }
arrow-array = "56.2"
arrow-schema = "56.2"
arrow-ipc = "56.2"
datafusion = { version = "50.3", default-features = false }
arrow = { version = "57", features = ["pyarrow"] }
arrow-array = "57"
arrow-schema = "57"
arrow-ipc = "57"
datafusion = { version = "51", default-features = false }
futures = "0.3"
lance-graph = { path = "../lance-graph" }
serde = { version = "1", features = ["derive"] }
Expand Down
26 changes: 13 additions & 13 deletions crates/lance-graph/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ keywords = ["lance", "graph", "cypher", "query", "datafusion"]
categories = ["database", "data-structures", "science"]

[dependencies]
arrow = { version = "56.2", features = ["prettyprint"] }
arrow-array = "56.2"
arrow-schema = "56.2"
datafusion = { version = "50.3", default-features = false, features = [
arrow = { version = "57", features = ["prettyprint"] }
arrow-array = "57"
arrow-schema = "57"
datafusion = { version = "51", default-features = false, features = [
"nested_expressions",
"regex_expressions",
"unicode_expressions",
Expand All @@ -23,15 +23,15 @@ datafusion = { version = "50.3", default-features = false, features = [
"datetime_expressions",
"string_expressions",
] }
datafusion-common = "50.3"
datafusion-expr = "50.3"
datafusion-sql = "50.3"
datafusion-functions-aggregate = "50.3"
datafusion-common = "51"
datafusion-expr = "51"
datafusion-sql = "51"
datafusion-functions-aggregate = "51"
futures = "0.3"
lance-graph-catalog = { path = "../lance-graph-catalog", version = "0.5.3" }
lance = "1.0.0"
lance-linalg = "1.0.0"
lance-namespace = "1.0.1"
lance = "2"
lance-linalg = "2"
lance-namespace = "2"
nom = "7.1"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
Expand All @@ -40,8 +40,8 @@ snafu = "0.8"
[dev-dependencies]
criterion = { version = "0.5", features = ["async", "async_tokio", "html_reports"] }
futures = "0.3"
lance-arrow = "1.0.0"
lance-index = "1.0.0"
lance-arrow = "2"
lance-index = "2"
tempfile = "3"
tokio = { version = "1.37", features = ["macros", "rt-multi-thread"] }

Expand Down