Skip to content

Commit c3e9f4b

Browse files
committed
Enable cooldown numbers option in Classic Era, since it works there (not sure when that was added)
1 parent 8ee0c3a commit c3e9f4b

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

Addon.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ local OPieParams = {
288288
name="Masque",
289289
apiLevel=3,
290290
CreateIndicator=CreateIndicator,
291-
supportsCooldownNumbers=ver >= 30401 and true or false,
291+
supportsCooldownNumbers=true,
292292
supportsShortLabels=false,
293293
onParentAlphaChanged=onParentAlphaChanged,
294294
}

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Version 11.2.7.1
22

3+
- Removed Classic Era limitation for showing cooldown numbers since they are fully supported in all game versions
34
- Updated TOC for Retail 12.0.0 (Beta)
45
- Updated TOC for Burning Crusade Classic 2.5.5 (PTR)
56
- Updated TOC for Pandaria Classic 5.5.3 (PTR)

README.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ You can install this addon from [CurseForge](https://www.curseforge.com/wow/addo
88

99
OPie Masque registers as a skin for OPie and should support any skin compatible with Masque. When no other OPie skins are installed, OPie Masque should become the default skin automatically. If not, you can change the skin from the OPie addon settings panel under the Appearance section. You can then choose a Masque skin you have installed from the Masque Skin Settings panel for the OPie group or globally.
1010

11-
Recharge and cooldown numbers are handled by WoW natively in Retail and Pandaria Classic, and they will appear on OPie automatically assuming the following conditions are met:
11+
Recharge and cooldown numbers are handled by WoW natively and they will appear on OPie automatically assuming the following conditions are met:
1212

13-
- You are running the Retail or Pandaria Classic version of the game
1413
- The WoW option Action Bars > "Show Numbers for Cooldowns" is enabled
1514
- The OPie options "Show cooldown numbers" or "Show recharge numbers" are enabled (according to your preference)
1615

@@ -20,11 +19,7 @@ There are no separate options for OPie Masque implemented at this time.
2019

2120
## Classic Support
2221

23-
Classic is missing many features from Retail, but OPie and Masque offer full support for Classic, so OPie Masque inherits that support for the most part. However, "Show cooldown numbers" and "Show recharge numbers" are both unavailable in Classic Era as they rely on built-in functionality from Retail.
24-
25-
If you want this functionality in Classic Era, [OmniCC](https://github.com/tullamods/OmniCC) ([Curseforge](https://www.curseforge.com/wow/addons/omni-cc), [Wago](https://addons.wago.io/addons/omnicc), [WoWInterface](https://www.wowinterface.com/downloads/info4836-OmniCC.html)) should work, though it will not honor OPie's cooldown number options.
26-
27-
I've done limited testing with Classic Era and Pandaria Classic because I don't play them, but I believe everything should work. If you report bugs or submit patches, I'll do my best to address them.
22+
I've done limited testing with Classic versions because I don't play them, but I believe everything should work. If you report bugs or submit patches, I'll do my best to address them.
2823

2924
## Special Thanks
3025

0 commit comments

Comments
 (0)