Skip to content

Commit ff2b250

Browse files
timmolterCopilot
andcommitted
Fix remaining IDE warnings in xchart-demo and xchart-site
- Remove unused local variables (series1/2 in BarChart11, staked1/2/3 in BarChart12, series in DialChart02/LineChart08, bubbleSeries in TestForIssue545, min/max/nbInstances in TestForIssue390) - Parameterize XChartPanel raw types in ChartStylePanel and XChartStyleDemo - Fix raw Chart type in TestForIssue1 (List<Chart> -> List<XYChart>) - Remove unnecessary @SuppressWarnings("unchecked") in GenerateSite - Remove now-unused series imports after variable removals Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 07f5aa6 commit ff2b250

10 files changed

Lines changed: 16 additions & 26 deletions

File tree

xchart-demo/src/main/java/org/knowm/xchart/demo/ChartStylePanel.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,9 +526,9 @@ public TableCellEditor getCellEditor(int row, int column) {
526526
}
527527

528528
private EditorTable table;
529-
private XChartPanel chartPanel;
529+
private XChartPanel<?> chartPanel;
530530

531-
public ChartStylePanel(XChartPanel chartPanel) {
531+
public ChartStylePanel(XChartPanel<?> chartPanel) {
532532
this.chartPanel = chartPanel;
533533
table = new EditorTable(this, chartPanel.getChart());
534534
JScrollPane scrollpane = new JScrollPane(table);
@@ -538,7 +538,7 @@ public ChartStylePanel(XChartPanel chartPanel) {
538538
setPreferredSize(new Dimension(800, 600));
539539
}
540540

541-
public void changeChart(XChartPanel chartPanel) {
541+
public void changeChart(XChartPanel<?> chartPanel) {
542542

543543
this.chartPanel = chartPanel;
544544
table.changeChart(chartPanel.getChart());

xchart-demo/src/main/java/org/knowm/xchart/demo/XChartStyleDemo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public XChartStyleDemo() {
2121

2222
@Override
2323
public void valueChanged(TreeSelectionEvent e) {
24-
XChartPanel oldChartPanel = chartPanel;
24+
XChartPanel<?> oldChartPanel = chartPanel;
2525
super.valueChanged(e);
2626
if (chartPanel != oldChartPanel) {
2727
stylePanel.changeChart(chartPanel);

xchart-demo/src/main/java/org/knowm/xchart/demo/charts/bar/BarChart11.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import java.util.Random;
66
import org.knowm.xchart.CategoryChart;
77
import org.knowm.xchart.CategoryChartBuilder;
8-
import org.knowm.xchart.CategorySeries;
98
import org.knowm.xchart.SwingWrapper;
109
import org.knowm.xchart.demo.charts.ExampleChart;
1110

@@ -72,10 +71,8 @@ public CategoryChart getChart() {
7271
chart.getStyler().setLabelsRotation(45);
7372

7473
// Series
75-
CategorySeries series1 =
76-
chart.addSeries("series1", getLinearValues(0, 200, 6), getRandomValues(10, 50, 6));
77-
CategorySeries series2 =
78-
chart.addSeries("series2", getLinearValues(0, 200, 6), getRandomValues(10, 50, 6));
74+
chart.addSeries("series1", getLinearValues(0, 200, 6), getRandomValues(10, 50, 6));
75+
chart.addSeries("series2", getLinearValues(0, 200, 6), getRandomValues(10, 50, 6));
7976

8077
return chart;
8178
}

xchart-demo/src/main/java/org/knowm/xchart/demo/charts/bar/BarChart12.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ public CategoryChart getChart() {
8585
}
8686

8787
// Series
88-
CategorySeries staked1 = chart.addSeries("Period 1", months, period1Values);
89-
CategorySeries staked2 = chart.addSeries("Period 2", months, period2Values);
90-
CategorySeries staked3 = chart.addSeries("Period 3", months, period3Values);
88+
chart.addSeries("Period 1", months, period1Values);
89+
chart.addSeries("Period 2", months, period2Values);
90+
chart.addSeries("Period 3", months, period3Values);
9191
CategorySeries overlappedLine = chart.addSeries("Average", months, averageValues);
9292
overlappedLine.setOverlapped(true);
9393
overlappedLine.setChartCategorySeriesRenderStyle(CategorySeries.CategorySeriesRenderStyle.Line);

xchart-demo/src/main/java/org/knowm/xchart/demo/charts/dial/DialChart02.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import java.awt.Font;
66
import org.knowm.xchart.DialChart;
77
import org.knowm.xchart.DialChartBuilder;
8-
import org.knowm.xchart.DialSeries;
98
import org.knowm.xchart.SwingWrapper;
109
import org.knowm.xchart.XChartPanel;
1110
import org.knowm.xchart.demo.charts.ExampleChart;
@@ -46,7 +45,7 @@ public DialChart getChart() {
4645
.build();
4746

4847
// Series
49-
DialSeries series = chart.addSeries("Rate", 0.55, "55 %");
48+
chart.addSeries("Rate", 0.55, "55 %");
5049

5150
chart.getStyler().setLegendVisible(true);
5251
chart.getStyler().setArcAngle(330);

xchart-demo/src/main/java/org/knowm/xchart/demo/charts/line/LineChart08.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public XYChart getChart() {
6262
// chart.getStyler().setXAxisLabelRotation(0);
6363

6464
// Series
65-
XYSeries series = chart.addSeries("10^x", xData, yData);
65+
chart.addSeries("10^x", xData, yData);
6666

6767
return chart;
6868
}

xchart-demo/src/main/java/org/knowm/xchart/standalone/issues/TestForIssue1.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
import org.knowm.xchart.BitmapEncoder;
66
import org.knowm.xchart.BitmapEncoder.BitmapFormat;
77
import org.knowm.xchart.XYChart;
8-
import org.knowm.xchart.internal.chartpart.Chart;
8+
99

1010
/** Creates a list of Charts and saves it as a PNG file. */
1111
public class TestForIssue1 {
1212

1313
public static void main(String[] args) throws Exception {
1414

15-
List<Chart> charts =
15+
List<XYChart> charts =
1616
Arrays.asList(
17-
new Chart[] {
17+
new XYChart[] {
1818
createChart("chart1", new double[] {2.0, 1.0, 0.0}),
1919
createChart("chart2", new double[] {3.0, 4.0, 0.0}),
2020
createChart("chart3", new double[] {4.0, 1.5, 0.0}),

xchart-demo/src/main/java/org/knowm/xchart/standalone/issues/TestForIssue390.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@ public static XYChart getChart() {
1616

1717
Random rand = new Random();
1818

19-
double min = 0;
20-
double max = 20;
2119
int nbServices = 20;
22-
int nbInstances = 50;
2320

2421
long s = 24;
2522
rand.setSeed(s);

xchart-demo/src/main/java/org/knowm/xchart/standalone/issues/TestForIssue545.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import java.text.ParseException;
55
import org.knowm.xchart.BubbleChart;
66
import org.knowm.xchart.BubbleChartBuilder;
7-
import org.knowm.xchart.BubbleSeries;
87
import org.knowm.xchart.SwingWrapper;
98
import org.knowm.xchart.style.BubbleStyler;
109
import org.knowm.xchart.style.Styler;
@@ -31,9 +30,8 @@ public static BubbleChart getBubbleChart() {
3130
.yAxisTitle("Rate")
3231
.build();
3332
setBubbleStyler(chart);
34-
BubbleSeries bubbleSeries =
35-
chart.addSeries(
36-
"serieName", new double[] {data[0]}, new double[] {data[1]}, new double[] {data[2]});
33+
chart.addSeries(
34+
"serieName", new double[] {data[0]}, new double[] {data[1]}, new double[] {data[2]});
3735
// bubbleSeries.setCustomToolTips(true);
3836
// String tooltip =
3937
// new DecimalFormat("#%").format(data[1]) + " (" + ((int) data[2]) + "/" + ((int)

xchart-site/src/main/java/org/knowm/xchart/site/GenerateSite.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,6 @@ private String buildFooter() {
416416

417417
// ── Package scanning ─────────────────────────────────────────────────────────
418418

419-
@SuppressWarnings("unchecked")
420419
private List<Class<?>> scanPackage(String packageName) throws Exception {
421420
List<Class<?>> classes = new ArrayList<>();
422421
String packagePath = packageName.replace('.', '/');

0 commit comments

Comments
 (0)