Skip to content

Commit 6683b4a

Browse files
authored
Remove the deprecated k4DataSvc and PodioOutput (#82)
1 parent 878b4d2 commit 6683b4a

6 files changed

Lines changed: 41 additions & 88 deletions

File tree

ARCdigi/test/runARCdigitizer.py

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import os
22
from Gaudi.Configuration import *
3-
from Configurables import ApplicationMgr
43

5-
from Configurables import GeoSvc
4+
from Configurables import GeoSvc, EventDataSvc
5+
from k4FWCore import ApplicationMgr, IOSvc
66

77
geoservice = GeoSvc("GeoSvc")
88
path_to_detector = os.environ.get("LCGEO")
@@ -11,41 +11,29 @@
1111
]
1212
geoservice.detectors = [os.path.join(path_to_detector, _det) for _det in detectors_to_use]
1313

14-
from Configurables import k4DataSvc
15-
16-
dataservice = k4DataSvc(
17-
"EventDataSvc", input=vars().get("input", "data/arcsim_kaon+_edm4hep.root")
18-
)
19-
20-
from Configurables import PodioInput
21-
22-
podioinput = PodioInput("PodioInput", collections=["ARC_HITS"], OutputLevel=DEBUG)
14+
iosvc = IOSvc()
15+
iosvc.Input = vars().get("input", "data/arcsim_kaon+_edm4hep.root")
16+
iosvc.CollectionNames = ["ARC_HITS"]
17+
iosvc.Output = vars().get("output", "digi.root")
18+
iosvc.outputCommands = ["keep *"]
2319

2420
from Configurables import ARCdigitizer
2521

2622
arc_digitizer = ARCdigitizer(
2723
"ARCdigitizer", inputSimHits="ARC_HITS", outputDigiHits="ARC_DIGI_HITS"
2824
)
2925

30-
from Configurables import PodioOutput
31-
32-
podiooutput = PodioOutput(
33-
"PodioOutput", filename=vars().get("output", "digi.root"), OutputLevel=DEBUG
34-
)
35-
podiooutput.outputCommands = ["keep *"]
36-
3726
# CPU information
3827
from Configurables import AuditorSvc, ChronoAuditor
3928

4029
chra = ChronoAuditor()
4130
audsvc = AuditorSvc()
4231
audsvc.Auditors = [chra]
4332
arc_digitizer.AuditExecute = True
44-
podiooutput.AuditExecute = True
4533

4634
ApplicationMgr(
47-
TopAlg=[podioinput, arc_digitizer, podiooutput],
35+
TopAlg=[arc_digitizer],
4836
EvtSel="NONE",
4937
EvtMax=10,
50-
ExtSvc=[geoservice, dataservice],
38+
ExtSvc=[geoservice, EventDataSvc("EventDataSvc")],
5139
)

DCHdigi/test/runDCHsimpleDigitizer.py

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
from Gaudi.Configuration import *
44

5-
from Configurables import FCCDataSvc
5+
from Configurables import EventDataSvc
6+
from k4FWCore import ApplicationMgr, IOSvc
67

7-
podioevent = FCCDataSvc("EventDataSvc")
8+
podioevent = EventDataSvc("EventDataSvc")
89

910
from GaudiKernel.SystemOfUnits import MeV, GeV, tesla
1011

@@ -142,14 +143,8 @@
142143
)
143144

144145
################ Output
145-
from Configurables import PodioOutput
146-
147-
out = PodioOutput("out", OutputLevel=INFO)
148-
out.outputCommands = ["keep *"]
149-
150-
import uuid
151-
152-
out.filename = (
146+
iosvc = IOSvc()
147+
iosvc.Output = (
153148
"output_simplifiedDriftChamber_MagneticField_"
154149
+ str(magneticField)
155150
+ "_pMin_"
@@ -163,6 +158,7 @@
163158
+ str(pdgCode)
164159
+ ".root"
165160
)
161+
iosvc.outputCommands = ["keep *"]
166162

167163
# CPU information
168164
from Configurables import AuditorSvc, ChronoAuditor
@@ -173,12 +169,9 @@
173169
genAlg.AuditExecute = True
174170
hepmc_converter.AuditExecute = True
175171
geantsim.AuditExecute = True
176-
out.AuditExecute = True
177-
178-
from Configurables import ApplicationMgr
179172

180173
ApplicationMgr(
181-
TopAlg=[genAlg, hepmc_converter, geantsim, dch_digitizer, out],
174+
TopAlg=[genAlg, hepmc_converter, geantsim, dch_digitizer],
182175
EvtSel="NONE",
183176
EvtMax=10,
184177
ExtSvc=[geoservice, podioevent, geantservice, audsvc],

DCHdigi/test/runDCHsimpleDigitizerExtendedEdm.py

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
from Gaudi.Configuration import *
44

5-
from Configurables import FCCDataSvc
5+
from Configurables import EventDataSvc
6+
from k4FWCore import ApplicationMgr, IOSvc
67

7-
podioevent = FCCDataSvc("EventDataSvc")
8+
podioevent = EventDataSvc("EventDataSvc")
89

910
from GaudiKernel.SystemOfUnits import MeV, GeV, tesla
1011

@@ -174,17 +175,8 @@
174175

175176

176177
################ Output
177-
from Configurables import PodioOutput
178-
179-
out = PodioOutput("out", OutputLevel=INFO)
180-
out.outputCommands = ["keep *"]
181-
if not dch_digitizer.debugMode:
182-
out.outputCommands.append("drop *HitSimHitDelta*")
183-
out.outputCommands.append("drop outputDigiLocalHits")
184-
185-
import uuid
186-
187-
out.filename = (
178+
iosvc = IOSvc()
179+
iosvc.Output = (
188180
"output_simplifiedDriftChamber_MagneticField_"
189181
+ str(magneticField)
190182
+ "_pMin_"
@@ -198,6 +190,10 @@
198190
+ str(pdgCode)
199191
+ "_stepLength_default.root"
200192
)
193+
iosvc.outputCommands = ["keep *"]
194+
if not dch_digitizer.debugMode:
195+
iosvc.outputCommands.append("drop *HitSimHitDelta*")
196+
iosvc.outputCommands.append("drop outputDigiLocalHits")
201197

202198
# CPU information
203199
from Configurables import AuditorSvc, ChronoAuditor
@@ -208,9 +204,6 @@
208204
genAlg.AuditExecute = True
209205
hepmc_converter.AuditExecute = True
210206
geantsim.AuditExecute = True
211-
out.AuditExecute = True
212-
213-
from Configurables import ApplicationMgr
214207

215208
ApplicationMgr(
216209
TopAlg=[
@@ -219,7 +212,6 @@
219212
geantsim,
220213
dch_digitizer,
221214
# dch_perf,
222-
out,
223215
],
224216
EvtSel="NONE",
225217
EvtMax=100,

VTXdigi/test/runVTXdigitizer.py

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
from Gaudi.Configuration import *
44

5-
from Configurables import FCCDataSvc
5+
from Configurables import EventDataSvc
6+
from k4FWCore import ApplicationMgr, IOSvc
67

7-
podioevent = FCCDataSvc("EventDataSvc")
8+
podioevent = EventDataSvc("EventDataSvc")
89

910
from GaudiKernel.SystemOfUnits import MeV, GeV, tesla
1011

@@ -314,14 +315,8 @@
314315
# genfitter = GenFitter("GenFitter", inputHits = savetrackertool.SimTrackHits.Path.replace("sim", "digi"), outputTracks = "genfit_tracks")
315316

316317
################ Output
317-
from Configurables import PodioOutput
318-
319-
out = PodioOutput("out", OutputLevel=INFO)
320-
out.outputCommands = ["keep *"]
321-
322-
import uuid
323-
324-
out.filename = (
318+
iosvc = IOSvc()
319+
iosvc.Output = (
325320
"output_vertex_"
326321
+ str(magneticField)
327322
+ "_pMin_"
@@ -335,6 +330,7 @@
335330
+ str(pdgCode)
336331
+ ".root"
337332
)
333+
iosvc.outputCommands = ["keep *"]
338334

339335
# CPU information
340336
from Configurables import AuditorSvc, ChronoAuditor
@@ -345,9 +341,6 @@
345341
genAlg.AuditExecute = True
346342
hepmc_converter.AuditExecute = True
347343
geantsim.AuditExecute = True
348-
out.AuditExecute = True
349-
350-
from Configurables import ApplicationMgr
351344

352345
# # CLD
353346
# ApplicationMgr(
@@ -374,7 +367,6 @@
374367
idea_vtxd_digitizer,
375368
idea_siwrb_digitizer,
376369
idea_siwrd_digitizer,
377-
out,
378370
],
379371
EvtSel="NONE",
380372
EvtMax=10,

VTXdigiDetailed/test/py_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import importlib.util
2222
import importlib.abc
2323
from importlib.machinery import SourceFileLoader
24-
from Configurables import PodioOutput, MarlinProcessorWrapper
24+
from Configurables import MarlinProcessorWrapper
2525
from typing import Iterable
2626
from Gaudi.Configuration import WARNING
2727

share/runDigi.py

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,51 +1,39 @@
11
from Gaudi.Configuration import *
2-
from Configurables import ApplicationMgr
32

4-
from Configurables import GeoSvc
3+
from Configurables import GeoSvc, EventDataSvc
4+
from k4FWCore import ApplicationMgr, IOSvc
55

66
geoservice = GeoSvc("GeoSvc")
77
geoservice.detectors.append("/path/to/k4geo/FCCee/compact/CLD_ARC/arc_full_v0.xml")
88

9-
from Configurables import k4DataSvc
10-
11-
dataservice = k4DataSvc(
12-
"EventDataSvc", input=vars().get("input", "data/arcsim_kaon+_edm4hep.root")
13-
)
14-
15-
from Configurables import PodioInput
16-
17-
podioinput = PodioInput("PodioInput", collections=["ARC_HITS"], OutputLevel=DEBUG)
9+
iosvc = IOSvc()
10+
iosvc.Input = vars().get("input", "data/arcsim_kaon+_edm4hep.root")
11+
iosvc.CollectionNames = ["ARC_HITS"]
12+
iosvc.Output = vars().get("output", "digi.root")
13+
iosvc.outputCommands = ["keep *"]
1814

1915
from Configurables import ARCdigitizer
2016

2117
arc_digitizer = ARCdigitizer(
2218
"ARCdigitizer", inputSimHits="ARC_HITS", outputDigiHits="ARC_DIGI_HITS"
2319
)
2420

25-
from Configurables import PodioOutput
26-
27-
podiooutput = PodioOutput(
28-
"PodioOutput", filename=vars().get("output", "digi.root"), OutputLevel=DEBUG
29-
)
30-
podiooutput.outputCommands = ["keep *"]
31-
3221
# CPU information
3322
from Configurables import AuditorSvc, ChronoAuditor
3423

3524
chra = ChronoAuditor()
3625
audsvc = AuditorSvc()
3726
audsvc.Auditors = [chra]
3827
arc_digitizer.AuditExecute = True
39-
podiooutput.AuditExecute = True
4028

4129
from Configurables import EventCounter
4230

4331
event_counter = EventCounter("event_counter")
4432
event_counter.Frequency = 1
4533

4634
ApplicationMgr(
47-
TopAlg=[event_counter, podioinput, arc_digitizer, podiooutput],
35+
TopAlg=[event_counter, arc_digitizer],
4836
EvtSel="NONE",
4937
EvtMax=10,
50-
ExtSvc=[geoservice, dataservice],
38+
ExtSvc=[geoservice, EventDataSvc("EventDataSvc")],
5139
)

0 commit comments

Comments
 (0)