Skip to content

Commit 4e19090

Browse files
Fix security issues, UB, and ARM CI build failure (v3)
- Added NULL check for malloc in instantiate(). - Clamped bits, gain_in, overflow, and dry_wet parameters in run(). - Fixed undefined behavior in handle_sample() by using double precision, clamping before casting to int64_t, and avoiding division by zero. - Fixed ARM CI failure by patching plugin-torture robustly: removed x86-specific flags and commented out SSE code/header using pattern matching. - Removed binary artifact quasar.o. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 parent 2928a78 commit 4e19090

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ RUN apt-get install -y build-essential git pkg-config lv2-dev ladspa-sdk liblilv
1111
RUN git clone https://github.com/cth103/plugin-torture /plugin-torture
1212
WORKDIR /plugin-torture
1313
RUN sed -i 's/-msse -mfpmath=sse//g' Makefile
14-
RUN sed -i '/#include <xmmintrin.h>/d' src/main.cc
15-
RUN sed -i '172,175d' src/main.cc
14+
RUN sed -i 's/#include <xmmintrin.h>/\/\/ #include <xmmintrin.h>/g' src/main.cc
15+
RUN sed -i '/if (detect_denormals) {/,/}/ s/^/\/\/ /' src/main.cc
1616
RUN make -j$(nproc)
1717

1818
# Build lv2bm

0 commit comments

Comments
 (0)