-
Notifications
You must be signed in to change notification settings - Fork 12
Move pin colour detection to browser #225
Copy link
Copy link
Open
Labels
01 refactoringnot a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/not a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/20 frontendChanges in Frontend requiredChanges in Frontend required
Metadata
Metadata
Assignees
Labels
01 refactoringnot a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/not a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/20 frontendChanges in Frontend requiredChanges in Frontend required
Type
Projects
Status
New Issues
Problem
A clear and concise description of the bug.
for the rate limit issue I can move the tag-color matching to the client's browser instead of server.
Pros: less rate limit, if we change the balloon's color while users are browsing, they won't see the changes in realtime unless they refresh the page.
Cons: will consume user's memory and if the list of color tags grow they may face halted situations.
my recommendation: move the tag-color matching to the browser instead of server because when the csv is small it works on the fly. but we keep the api as well in case we needed to rollback to the server edition.
what do you suggest?