Skip to content

Commit 052c193

Browse files
ci: rename images #6
1 parent 9cef7ad commit 052c193

5 files changed

Lines changed: 22 additions & 46 deletions

File tree

.github/workflows/main.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ on:
88
default: false
99
required: false
1010
type: boolean
11-
build_service:
12-
description: "Build service"
11+
build_api:
12+
description: "Build api"
1313
default: false
1414
required: false
1515
type: boolean
16-
build_ingestion_job:
17-
description: "Build ingestion job"
16+
build_ingestion:
17+
description: "Build ingestion"
1818
default: false
1919
required: false
2020
type: boolean
@@ -47,8 +47,8 @@ jobs:
4747
env:
4848
SOPS_AGE_KEY: ${{ secrets.SOPS_AGE_KEY }}
4949
run: bash ./scripts/run_tests.sh -s -r ${{ github.job }}
50-
build_service:
51-
name: Build service
50+
build_api:
51+
name: Build api
5252
if: ${{ !contains(github.event.head_commit.message, 'skip build') }}
5353
runs-on: ubuntu-22.04
5454
steps:
@@ -62,12 +62,12 @@ jobs:
6262
env:
6363
KALISIO_GITHUB_URL: ${{ secrets.KALISIO_GITHUB_URL }}
6464
run: bash ./scripts/setup_workspace.sh
65-
- name: Build service
65+
- name: Build api
6666
env:
6767
SOPS_AGE_KEY: ${{ secrets.SOPS_AGE_KEY }}
68-
run: bash ./scripts/build_service.sh -p -r ${{ github.job }}
69-
build_ingestion_job:
70-
name: Build ingestion job
68+
run: bash ./scripts/build_api.sh -p -r ${{ github.job }}
69+
build_ingestion:
70+
name: Build ingestion
7171
runs-on: ubuntu-22.04
7272
steps:
7373
- name: Checkout repo
@@ -80,10 +80,10 @@ jobs:
8080
env:
8181
KALISIO_GITHUB_URL: ${{ secrets.KALISIO_GITHUB_URL }}
8282
run: bash ./scripts/setup_workspace.sh
83-
- name: Build service
83+
- name: Build ingestion
8484
env:
8585
SOPS_AGE_KEY: ${{ secrets.SOPS_AGE_KEY }}
86-
run: bash ./scripts/build_ingestion_job.sh -p -r ${{ github.job }}
86+
run: bash ./scripts/build_ingestion.sh -p -r ${{ github.job }}
8787
build_docs:
8888
name: Build docs
8989
if: ${{
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ WORKSPACE_DIR="$(dirname "$ROOT_DIR")"
1313
##
1414

1515
PUBLISH=false
16-
CI_STEP_NAME="Build service"
16+
CI_STEP_NAME="Build api"
1717
while getopts "pr:" option; do
1818
case $option in
1919
p) # publish app
@@ -32,7 +32,9 @@ done
3232
## Init workspace
3333
##
3434

35-
NAME=$(get_toml_value "$ROOT_DIR/pyproject.toml" 'project.name')
35+
## Same shape as the ingestion image (knowledge-ingestion): the project name
36+
## plus the component the image runs.
37+
NAME="$(get_toml_value "$ROOT_DIR/pyproject.toml" 'project.name')-api"
3638
VERSION=$(get_toml_value "$ROOT_DIR/pyproject.toml" 'project.version')
3739
GIT_TAG=$(get_git_tag "$ROOT_DIR")
3840

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ WORKSPACE_DIR="$(dirname "$ROOT_DIR")"
1313
##
1414

1515
PUBLISH=false
16-
CI_STEP_NAME="Build ingestion job"
16+
CI_STEP_NAME="Build ingestion"
1717
while getopts "pr:" option; do
1818
case $option in
1919
p) # publish app
@@ -32,7 +32,9 @@ done
3232
## Init workspace
3333
##
3434

35-
NAME="$(get_toml_value "$ROOT_DIR/pyproject.toml" 'project.name')-job"
35+
## Same shape as the api image (knowledge-api): the project name plus the
36+
## component the image runs.
37+
NAME="$(get_toml_value "$ROOT_DIR/pyproject.toml" 'project.name')-ingestion"
3638
VERSION=$(get_toml_value "$ROOT_DIR/pyproject.toml" 'project.version')
3739

3840
echo "About to build $NAME v$VERSION ..."

scripts/init_runner.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ init_github_run_tests() {
1515
install_reqs age sops sonar_scanner_cli micromamba
1616
}
1717

18-
init_github_build_service() {
18+
init_github_build_api() {
1919
install_reqs age sops
2020
}
2121

22-
init_github_build_ingestion_job() {
22+
init_github_build_ingestion() {
2323
install_reqs age sops
2424
}
2525

scripts/setup_notebook_data.sh

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)