Fix vector functions#345
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
==========================================
+ Coverage 90.73% 91.16% +0.42%
==========================================
Files 16 16
Lines 2300 2457 +157
==========================================
+ Hits 2087 2240 +153
- Misses 213 217 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Open question: |
|
@odow do you want to comment on the proposed functions in jump_wrapper.jl? |
| ForwardObjectiveFunction(), | ||
| JuMP.moi_function(func), | ||
| ) | ||
| end |
There was a problem hiding this comment.
The other option for this is
set_attribute(model, DiffOpt.ForwardObjectiveFunction(), func)It requires fewer new functions.
| JuMP.index(con_ref), | ||
| JuMP.moi_function(func), | ||
| ) | ||
| end |
There was a problem hiding this comment.
This one would be
set_attribute(con_ref, ForwardConstraintFunction(), func)There was a problem hiding this comment.
We tend not to require both model and con_ref when model = owner_model(con_ref)
There was a problem hiding this comment.
Yeah, I noticed this after finishing.
I also think I prefer without the model.
3 participants
Most important to agree on are the functions on jump_wrapper.jl
Later on, we will need to deprecate the MOI functions that are not compliant with #288
Claude helped me with the bridging stuff and created first version of tests.
close #103
close #283
close #288
close #305