chore: update repairs

Author: jpawlowski

custom_components/action_result/__init__.py

@@ -26,6 +26,7 @@
 from homeassistant.const import Platform
 from homeassistant.core import Event, EventStateChangedData, callback
 from homeassistant.exceptions import ConfigEntryNotReady
+from homeassistant.helpers import issue_registry as ir
 import homeassistant.helpers.config_validation as cv
 from homeassistant.helpers.event import async_track_state_change_event
 from homeassistant.loader import async_get_loaded_integration
@@ -45,6 +46,7 @@
     DEFAULT_UPDATE_MODE,
     DOMAIN,
     LOGGER,
+    REPAIR_ISSUE_TRIGGER_ENTITY_MISSING,
     SENSOR_TYPE_DATA,
     SENSOR_TYPE_VALUE,
     UPDATE_MODE_POLLING,
@@ -249,6 +251,30 @@ def async_service_removed_listener(event: Event) -> None:
     if update_mode == UPDATE_MODE_STATE_TRIGGER:
         trigger_entity = entry.data.get(CONF_TRIGGER_ENTITY, "")
         if trigger_entity:
+            # Check if trigger entity exists
+            if not hass.states.get(trigger_entity):
+                # Create repair issue for missing trigger entity
+                entry_name = entry.data.get("name", "Unknown")
+                ir.async_create_issue(
+                    hass,
+                    DOMAIN,
+                    f"{REPAIR_ISSUE_TRIGGER_ENTITY_MISSING}_{entry.entry_id}",
+                    is_fixable=False,
+                    severity=ir.IssueSeverity.WARNING,
+                    translation_key="trigger_entity_missing",
+                    translation_placeholders={
+                        "entry_name": entry_name,
+                        "trigger_entity": trigger_entity,
+                    },
+                )
+                LOGGER.warning(
+                    "Trigger entity %s not found for config entry %s (%s). "
+                    "The integration will not update automatically until the entity becomes available.",
+                    trigger_entity,
+                    entry_name,
+                    entry.entry_id,
+                )
+
             trigger_from_state = entry.data.get(CONF_TRIGGER_FROM_STATE, "")
             trigger_to_state = entry.data.get(CONF_TRIGGER_TO_STATE, "")
 
@@ -259,8 +285,43 @@ def async_state_change_listener(event: Event[EventStateChangedData]) -> None:
                 new_state = event.data.get("new_state")
 
                 if new_state is None:
+                    # Entity was removed - create repair issue if it doesn't exist
+                    entry_name = entry.data.get("name", "Unknown")
+                    issue_id = f"{REPAIR_ISSUE_TRIGGER_ENTITY_MISSING}_{entry.entry_id}"
+
+                    # Check if issue already exists
+                    existing_issue = ir.async_get(hass).async_get_issue(DOMAIN, issue_id)
+                    if not existing_issue:
+                        ir.async_create_issue(
+                            hass,
+                            DOMAIN,
+                            issue_id,
+                            is_fixable=False,
+                            severity=ir.IssueSeverity.WARNING,
+                            translation_key="trigger_entity_missing",
+                            translation_placeholders={
+                                "entry_name": entry_name,
+                                "trigger_entity": trigger_entity,
+                            },
+                        )
+                        LOGGER.warning(
+                            "Trigger entity %s was removed for config entry %s (%s)",
+                            trigger_entity,
+                            entry_name,
+                            entry.entry_id,
+                        )
                     return
 
+                # Entity exists - delete repair issue if it exists
+                issue_id = f"{REPAIR_ISSUE_TRIGGER_ENTITY_MISSING}_{entry.entry_id}"
+                existing_issue = ir.async_get(hass).async_get_issue(DOMAIN, issue_id)
+                if existing_issue:
+                    ir.async_delete_issue(hass, DOMAIN, issue_id)
+                    LOGGER.info(
+                        "Trigger entity %s is now available again, repair issue removed",
+                        trigger_entity,
+                    )
+
                 old_state_value = old_state.state if old_state else None
                 new_state_value = new_state.state
 
@@ -318,7 +379,7 @@ async def async_unload_entry(
     Unload a config entry.
 
     This is called when the integration is being removed or reloaded.
-    It ensures proper cleanup of all platform entities.
+    It ensures proper cleanup of all platform entities and repair issues.
 
     Args:
         hass: The Home Assistant instance.
@@ -327,6 +388,13 @@ async def async_unload_entry(
     Returns:
         True if unload was successful.
     """
+    # Clean up any repair issues for this entry
+    issue_id = f"{REPAIR_ISSUE_TRIGGER_ENTITY_MISSING}_{entry.entry_id}"
+    existing_issue = ir.async_get(hass).async_get_issue(DOMAIN, issue_id)
+    if existing_issue:
+        ir.async_delete_issue(hass, DOMAIN, issue_id)
+        LOGGER.debug("Removed repair issue %s during unload", issue_id)
+
     platforms = _get_platforms_for_entry(entry)
     return await hass.config_entries.async_unload_platforms(entry, platforms)
 

custom_components/action_result/const.py

@@ -90,3 +90,6 @@
 INITIAL_RETRY_DELAY_SECONDS = 30
 SERVICE_CALL_TIMEOUT_SECONDS = 30  # Timeout for service calls
 MAX_RETRY_DELAY_SECONDS = 300  # 5 minutes max backoff
+
+# Repair issue IDs
+REPAIR_ISSUE_TRIGGER_ENTITY_MISSING = "trigger_entity_missing"

custom_components/action_result/coordinator/base.py

@@ -34,7 +34,7 @@
     MAX_RETRY_DELAY_SECONDS,
     SERVICE_CALL_TIMEOUT_SECONDS,
 )
-from homeassistant.exceptions import ConfigEntryAuthFailed, HomeAssistantError, ServiceNotFound
+from homeassistant.exceptions import HomeAssistantError, ServiceNotFound
 from homeassistant.helpers import issue_registry as ir
 from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed
 from homeassistant.util import dt as dt_util
@@ -230,43 +230,12 @@ def _classify_error(self, exc: Exception) -> str:
         # Default to unknown (treat as potentially temporary)
         return ERROR_TYPE_UNKNOWN
 
-    def _is_auth_error(self, exc: Exception) -> bool:
-        """
-        Check if an exception represents an authentication/authorization error.
-
-        Auth errors should trigger a reauth flow instead of just marking
-        the entity as unavailable.
-
-        Args:
-            exc: The exception to check.
-
-        Returns:
-            True if this is an authentication error, False otherwise.
-        """
-        error_str = str(exc).lower()
-
-        # Authentication/authorization error indicators
-        auth_indicators = [
-            "unauthorized",
-            "forbidden",
-            "authentication failed",
-            "invalid api key",
-            "invalid token",
-            "invalid credentials",
-            "permission denied",
-            "access denied",
-            "401",
-            "403",
-        ]
-
-        return any(indicator in error_str for indicator in auth_indicators)
-
     def _create_repair_issue(self, issue_type: str, error_msg: str) -> None:
         """
         Create a repair issue for persistent problems.
 
         Args:
-            issue_type: Type of issue (service_not_found, auth_failed, etc.)
+            issue_type: Type of issue (service_not_found, service_call_failed, etc.)
             error_msg: Error message to display to user.
         """
         service_domain, service_name = self.get_service_info()
@@ -429,22 +398,6 @@ async def _async_update_data(self) -> dict[str, Any]:
             self.last_error_type = error_type
             self.consecutive_errors += 1
 
-            # Check if this is an authentication error
-            if self._is_auth_error(exc):
-                LOGGER.error(
-                    "Authentication error calling service %s for '%s': %s",
-                    service_full_name,
-                    entry_name,
-                    exc,
-                )
-                # Create repair issue for auth error
-                self._create_repair_issue(
-                    "auth_failed",
-                    str(exc),
-                )
-                # Raise ConfigEntryAuthFailed to trigger reauth flow
-                raise ConfigEntryAuthFailed(f"Authentication failed for {service_full_name}: {error_msg}") from exc
-
             if error_type == ERROR_TYPE_TEMPORARY:
                 self.is_retrying = True
                 LOGGER.warning(
@@ -511,7 +464,6 @@ async def _async_update_data(self) -> dict[str, Any]:
 
             # Delete repair issues if they exist
             self._delete_repair_issue("service_not_found")
-            self._delete_repair_issue("auth_failed")
             self._delete_repair_issue("service_call_failed")
 
             LOGGER.debug(

custom_components/action_result/manifest.json

@@ -9,5 +9,5 @@
   "integration_type": "service",
   "iot_class": "local_polling",
   "issue_tracker": "https://github.com/jpawlowski/hass.action_result/issues",
-  "version": "0.2.0"
+  "version": "0.3.0"
 }