Skip to content

Commit 3096059

Browse files
committed
fix(inference): rename misleading describe block in execute_regex_rules.test.ts
Address review feedback: the describe block was titled "skips empty and non-string field values" but the payload type is Record<string, string> so non-string values are impossible, and the test only covers empty strings. Renamed to "skips empty string fields". Reviewed-at: elastic#288758 (comment)
1 parent f9446b3 commit 3096059

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

x-pack/platform/plugins/shared/inference/server/workflow_anonymization/detection/execute_regex_rules.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ describe('executeRegexRules', () => {
161161
});
162162
});
163163

164-
describe('skips empty and non-string field values', () => {
164+
describe('skips empty string fields', () => {
165165
it('ignores empty string fields', () => {
166166
const rules = [r('IP', '\\b\\d+\\.\\d+\\.\\d+\\.\\d+\\b')];
167167
const records = [{ content: '', other: '10.0.0.1' }];

0 commit comments

Comments
 (0)