Merge pull request #502 from jborgers/master-remove-junit-test-for-pmd7

removed all junit tests, they have been removed from PMD7

Author: jborgers

sonar-pmd-plugin/src/main/resources/org/sonar/plugins/pmd/rules-unit-tests.xml

@@ -1,5 +1,6 @@
 <rules>
-  <rule key="JUnitStaticSuite">
+  <!--NOTE: the following rules have been removed in pmd-7
+   rule key="JUnitStaticSuite">
     <priority>MAJOR</priority>
     <configKey><![CDATA[rulesets/java/junit.xml/JUnitStaticSuite]]></configKey>
   </rule>
@@ -24,8 +25,7 @@
     <priority>MINOR</priority>
     <configKey><![CDATA[rulesets/java/junit.xml/UnnecessaryBooleanAssertion]]></configKey>
   </rule>
-  <!--NOTE: the following rules have been removed in pmd-7
-   rule key="UseAssertEqualsInsteadOfAssertTrue">
+  <rule key="UseAssertEqualsInsteadOfAssertTrue">
     <priority>MINOR</priority>
     <configKey><![CDATA[rulesets/java/junit.xml/UseAssertEqualsInsteadOfAssertTrue]]></configKey>
   </rule>
@@ -44,7 +44,7 @@
   <rule key="UseAssertTrueInsteadOfAssertEquals">
     <priority>MINOR</priority>
     <configKey><![CDATA[rulesets/java/junit.xml/UseAssertTrueInsteadOfAssertEquals]]></configKey>
-  </rule-->
+  </rule>
   <rule key="JUnitTestContainsTooManyAsserts">
     <priority>MAJOR</priority>
     <configKey><![CDATA[rulesets/java/junit.xml/JUnitTestContainsTooManyAsserts]]></configKey>
@@ -72,5 +72,5 @@
   <rule key="JUnit4TestShouldUseTestAnnotation">
     <priority>MAJOR</priority>
     <configKey><![CDATA[rulesets/java/migrating.xml/JUnit4TestShouldUseTestAnnotation]]></configKey>
-  </rule>
+  </rule-->
 </rules>

sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdUnitTestsRulesDefinitionTest.java

@@ -45,29 +45,31 @@ void test() {
                 .hasFieldOrPropertyWithValue("language", PmdConstants.LANGUAGE_JAVA_KEY);
 
         List<Rule> rules = repository.rules();
-        //assertThat(rules).hasSize(17); NOTE: 5 rules have been removed in pmd-7
-        assertThat(rules).hasSize(12);
+        //assertThat(rules).hasSize(17); NOTE: all junit rules have been removed in pmd-7
+        assertThat(rules).hasSize(0);
 
         for (Rule rule : rules) {
             assertThat(rule.key()).isNotNull();
+            // all junit rules have been removed in pmd-7
             assertThat(rule.key()).isIn(
-                    "JUnitStaticSuite",
-                    "JUnitSpelling",
-                    "JUnitAssertionsShouldIncludeMessage",
-                    "JUnitTestsShouldIncludeAssert",
-                    "TestClassWithoutTestCases",
-                    "UnnecessaryBooleanAssertion",
-                    //"UseAssertEqualsInsteadOfAssertTrue", // 5 rules have been removed in pmd-7
-                    //"UseAssertSameInsteadOfAssertTrue",
-                    //"UseAssertNullInsteadOfAssertTrue",
-                    //"SimplifyBooleanAssertion",
-                    //"UseAssertTrueInsteadOfAssertEquals",
-                    "JUnitTestContainsTooManyAsserts",
-                    "JUnit4SuitesShouldUseSuiteAnnotation",
-                    "JUnit4TestShouldUseAfterAnnotation",
-                    "JUnit4TestShouldUseBeforeAnnotation",
-                    "JUnit4TestShouldUseTestAnnotation",
-                    "JUnitUseExpected");
+//                    "JUnitStaticSuite",
+//                    "JUnitSpelling",
+//                    "JUnitAssertionsShouldIncludeMessage",
+//                    "JUnitTestsShouldIncludeAssert",
+//                    "TestClassWithoutTestCases",
+//                    "UnnecessaryBooleanAssertion",
+//                    "UseAssertEqualsInsteadOfAssertTrue",
+//                    "UseAssertSameInsteadOfAssertTrue",
+//                    "UseAssertNullInsteadOfAssertTrue",
+//                    "SimplifyBooleanAssertion",
+//                    "UseAssertTrueInsteadOfAssertEquals",
+//                    "JUnitTestContainsTooManyAsserts",
+//                    "JUnit4SuitesShouldUseSuiteAnnotation",
+//                    "JUnit4TestShouldUseAfterAnnotation",
+//                    "JUnit4TestShouldUseBeforeAnnotation",
+//                    "JUnit4TestShouldUseTestAnnotation",
+//                    "JUnitUseExpected"
+            );
             assertThat(rule.internalKey()).isNotNull();
             assertThat(rule.name()).isNotNull();
             assertThat(rule.htmlDescription()).isNotNull();