Skip to content

Commit 97680af

Browse files
committed
small doc fix HttpClientBuilderWithoutTimeouts
1 parent e049105 commit 97680af

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/main/resources/category/java/remoting.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -422,10 +422,9 @@ return HttpClientBuilder.create() // good
422422
language="java"
423423
message="Apache HttpClient builder is used and not all three timeouts are configured."
424424
externalInfoUrl="${doc_root}/JavaCodePerformance.md#IBI10">
425-
<description>Problem: for connectionRequestTimeout, connectTimeout, socketTimeout (using
426-
HttpComponentsClientHttpRequestFactory/RequestConfig) or readTimeout/responseTimeout (using RequestConfig v4/v5) and connectTimeout (using ConnectionConfig v5)
427-
the default timeout settings are not optimal in most cases. &#13;
428-
Solution: Set the timeouts explicitly to proper reasoned values. See best practice values via the link. Use
425+
<description>Problem: default timeout values for Apache HttpClient are often sub optimal (connectionRequestTimeout, connectTimeout, socketTimeout in HttpComponentsClientHttpRequestFactory;
426+
readTimeout/responseTimeout in RequestConfig v4/v5; and connectTimeout in ConnectionConfig v5) &#13;
427+
Solution: Set all these timeouts explicitly to proper reasoned values. See best practice values via the link. Use
429428
the setDefaultRequestConfig with a method with a RequestConfig object on HttpClient builders to set the
430429
timeouts. (jpinpoint-rules)
431430
</description>

0 commit comments

Comments
 (0)