Debug build crashes when resetting an atom within a fucntion

[ikappaki]

Issue Description

Jank asserts while trying to reset! an atom inside a function in a debug build:

Assertion failed! o.is_some()

Reproduction Steps

1. In a Debug build, start the REPL and define a function that resets an atom to nil:

$ build/jank repl
user=> jank nREPL server is running on nrepl://127.0.0.1:45241
(ns issue)
nil

issue=> (defn issue [] (reset! (atom 5) nil))
#'issue/issue

2. Call the function, it causes jank to hit an assertion:

issue=> (issue)
Assertion failed! o.is_some()
...
aborted (core dumped)

The same works correctly on a release build:

$ jank repl
jank nREPL server is running on nrepl://127.0.0.1:45951
user=> (defn issue [] (reset! (atom 5) nil))
#'user/issue

user=> (issue)
nil

jank health check

─ system ───────────────────────────────────────────────────────────────────────
─ ✅ operating system: linux
─ ✅ default triple: x86_64-unknown-linux-gnu

─ jank install ─────────────────────────────────────────────────────────────────
─ ✅ jank version: jank-0.1-alpha
─ ⚠️ jank assertions are enabled; performance will be impacted 
─ ✅ jank resource dir: ../lib/jank/0.1 
─ ✅ jank resolved resource dir: /home/chaos/src/jank/compiler+runtime/build/../lib/jank/0.1 (ignored for dev build)
─ ✅ jank user cache dir: /home/chaos/.cache/jank/x86_64-unknown-linux-gnu-e0bf08c7bc3b87e7987be8458246babd227e2fb6b0544498f381cabf1d20394c (not found)

Stack trace

Stack trace (most recent call first):
#0  0x00006505e8ec4416 in jtl::do_assertion_panic(jtl::immutable_string_view const&) at /home/chaos/src/jank/compiler+runtime/src/cpp/jtl/assert.cpp:11:5
#1  0x00006505e960015d in jank::runtime::obj::atom::reset(jank::runtime::oref<jank::runtime::object>) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/obj/atom.cpp:42:5
#2  0x00006505e906b085 in jank::runtime::reset(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/core.cpp:455:41
#3  0x00006505e94f53c3 in jank::runtime::obj::jit_function::call(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>) const at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/obj/jit_function.cpp:79:12
#4  0x00006505e94829f5 in jank::runtime::dynamic_call(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/core/call.cpp:62:24
#5  0x000078ccc4a810e6 
#6  0x00006505e94f518d in jank::runtime::obj::jit_function::call() const at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/obj/jit_function.cpp:61:12
#7  0x00006505e94826eb in jank::runtime::dynamic_call(jank::runtime::oref<jank::runtime::object>) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/core/call.cpp:22:24
#8  0x00006505e948aa6b in jank::runtime::oref<jank::runtime::object> jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0::operator()<jank::runtime::oref<jank::runtime::obj::nil> >(jank::runtime::oref<jank::runtime::obj::nil>) const at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/core/call.cpp:544:20
#9  0x00006505e948768b in auto jank::runtime::visit_seqable<jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0, jank::runtime::visit_seqable<jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0>(jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0 const&, jank::runtime::oref<jank::runtime::object>)::{lambda()#1}>(jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0 const&, jank::runtime::visit_seqable<jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0>(jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0 const&, jank::runtime::oref<jank::runtime::object>)::{lambda()#1} const&, jank::runtime::oref<jank::runtime::object>) requires (visitable<jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0>)&&(!(std::convertible_to<jank::runtime::visit_seqable<jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0>(jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0 const&, jank::runtime::oref<jank::runtime::object>)::{lambda()#1}, jank::runtime::oref<jank::runtime::object> >)) at /home/chaos/src/jank/compiler+runtime/include/cpp/jank/runtime/visit.hpp:259:16
#10 0x00006505e94874a0 in auto jank::runtime::visit_seqable<jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0>(jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>)::$_0 const&, jank::runtime::oref<jank::runtime::object>) at /home/chaos/src/jank/compiler+runtime/include/cpp/jank/runtime/visit.hpp:328:12
#11 0x00006505e948745c in jank::runtime::apply_to(jank::runtime::oref<jank::runtime::object>, jank::runtime::oref<jank::runtime::object>) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/core/call.cpp:531:12
#12 0x00006505e94f9ae9 in jank::runtime::obj::deferred_cpp_function::call(jank::runtime::oref<jank::runtime::object>) const at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/obj/deferred_cpp_function.cpp:69:12
#13 0x00006505e94826d3 in jank::runtime::dynamic_call(jank::runtime::oref<jank::runtime::object>) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/core/call.cpp:20:24
#14 0x00006505e98d896e in jank::evaluate::eval(jtl::ref<jank::analyze::expr::call>) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/evaluate.cpp:340:18
#15 0x00006505e99122f8 in auto jank::evaluate::eval(jtl::ref<jank::analyze::expression>)::$_0::operator()<jtl::ref<jank::analyze::expr::call> >(jtl::ref<jank::analyze::expr::call>) const at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/evaluate.cpp:267:52
#16 0x00006505e98d79b6 in auto jank::analyze::visit_expr<jank::evaluate::eval(jtl::ref<jank::analyze::expression>)::$_0>(jank::evaluate::eval(jtl::ref<jank::analyze::expression>)::$_0 const&, jtl::ref<jank::analyze::expression>) at /home/chaos/src/jank/compiler+runtime/include/cpp/jank/analyze/visit.hpp:54:16
#17 0x00006505e98d784f in jank::evaluate::eval(jtl::ref<jank::analyze::expression>) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/evaluate.cpp:267:5
#18 0x00006505e94c37d3 in jank::runtime::context::eval_string(jtl::immutable_string const&) const at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/context.cpp:198:13
#19 0x00006505e94c336d in jank::runtime::context::eval_file(jtl::immutable_string const&) at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/runtime/context.cpp:174:12
#20 0x00006505e8adab76 in jank::repl() at /home/chaos/src/jank/compiler+runtime/src/cpp/main.cpp:294:34
#21 0x00006505e8ad9186 in main::$_0::operator()(int, char const**) const at /home/chaos/src/jank/compiler+runtime/src/cpp/main.cpp:481:9
#22 0x00006505e8ad8d2e in main::$_0::__invoke(int, char const**) at /home/chaos/src/jank/compiler+runtime/src/cpp/main.cpp:399:60
#23 0x00006505e8ee45c8 in jank_init_with_pch at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/c_api.cpp:1061:14
#24 0x00006505e8ee4415 in jank_init at /home/chaos/src/jank/compiler+runtime/src/cpp/jank/c_api.cpp:1023:12
#25 0x00006505e8ad8cdd in main at /home/chaos/src/jank/compiler+runtime/src/cpp/main.cpp:399:10
#26 0x000078ccc442a1c9 in __libc_start_call_main at ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#27 0x000078ccc442a28a in __libc_start_main_impl at ./csu/../csu/libc-start.c:360:3
#28 0x00006505e8ad8bd4 in _start at /home/chaos/src/jank/compiler+runtime/build/jank-phase-1

OS Version Information

Ubuntu 24.4, macos 25.1

I acknowledge that:

• I have searched the jank repository (both open and closed Discussions and Issues) and confirm this is not a duplicate of an existing issue or discussion.
• I have checked the "Preview" tab on all text fields to ensure that everything looks right, and have wrapped all configuration and code in code blocks with a group of three backticks (```) on separate lines.

[jeaye]

Thanks for the report! The fix for this is to just remove the debug assertion at compiler+runtime/src/cpp/jank/runtime/obj/atom.cpp:42. It's incorrect. A PR for that is welcome!

This should be caught when we get the jank tests running for atom and reset! in the clojure-test-suite. We're still working on support for that test suite, which is why this issue can exist on main. If those tests haven't yet been written, that's another way you can help with this issue.

[ikappaki]

#751 (merged)